[BUGFIX] cleanup rollup warnings #6809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asset Size Report for 924ab54 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis |
rwjblue
reviewed
Nov 26, 2019
Comment on lines
52
to
73
| } else if (message.code === 'NON_EXISTENT_EXPORT') { | ||
| // ignore ts-interface imports | ||
| if (message.message.indexOf(`/ts-interfaces/`) !== -1) { | ||
| return; | ||
| } | ||
| } else if (message.code === 'UNRESOLVED_IMPORT') { | ||
| if (!this.isDevelopingAddon()) { | ||
| // don't print these for consumers | ||
| return; | ||
| } else { | ||
| // make warning actionable | ||
| // eslint-disable-next-line no-console | ||
| console.log( | ||
| chalk.yellow( | ||
| `\n\n⚠️ Add ${chalk.white( | ||
| message.source | ||
| )} to the array returned by externalDependenciesForPrivateModule in index.js of ${chalk.white( | ||
| this.name | ||
| )}\n\n` | ||
| ) | ||
| ); | ||
| return; |
There was a problem hiding this comment.
Instead of suppressing these, we should fail the build when developing. This will still have the same result (consumers will not see warnings), but actually forces us to ensure the repo is in the correct shape.
There was a problem hiding this comment.
@rwjblue I initially did make it throw but figured outputting a clear warning with specific guidance on how to fix it might be enough. I can still throw after this warning.
There was a problem hiding this comment.
Opened #6850 to address my concern.
|
Asset Size Report for 4c6041e EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.