-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] remove unneeded configs #6817
Conversation
Asset Size Report for 24bd752 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Seems reasonable to me, but would love to check with the resident ts experts. Do you know why we put it there in the first place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't know any better and our scaffolding generates files there for us. |
These configs simply re-export our root config, which doesn't provide any value over just having the root config but does introduce the risk that we make config edits in some packages we don't intend.
tsc uses our root config and vscode will always find it there as well. ember-cli-typescript likely doesn't need it at all but if it does we can point it to the right place.