-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX TESTS] matrix tests for fastboot & ie11 w/jquery & fetch #6831
Conversation
Asset Size Report for 163c93c IE11 Builds The size of the library EmberData has increased by 22.0 B (39.0 B compressed) which exceeds the failure threshold of 15 bytes.WarningsThe uncompressed size of the package @ember-data/adapter has increased by 22.0 B. Changeset
Full Asset Analysis (IE11)
Modern Builds The size of the library EmberData has increased by 22.0 B (44.0 B compressed) which exceeds the failure threshold of 15 bytes.WarningsThe uncompressed size of the package @ember-data/adapter has increased by 22.0 B. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) The size of the library EmberData has increased by 22.0 B (51.0 B compressed) which exceeds the failure threshold of 15 bytes.WarningsThe uncompressed size of the package @ember-data/adapter has increased by 22.0 B. Changeset
Full Asset Analysis (Modern)
|
Performance Report for 163c93c Relationship Analysis
|
22b2827
to
8a2e095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 after the comments
e14a880
to
dd8b8f6
Compare
resolves #6431
Bugfix: jQuery+fastboot
The added tests for fastboot revealed that fastboot+jQuery was broken because our computed property for getting the fastboot service wasn't setting and updating it's value properly leading to it always being false. This led us down the wrong code-path and ultimately meant that the url we provided to
najax
wasn't parsed correctly and would error.