Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Fix deprecation warnings; improve tooling #6836

Merged
merged 1 commit into from
Dec 2, 2019
Merged

[CHORE] Fix deprecation warnings; improve tooling #6836

merged 1 commit into from
Dec 2, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Dec 2, 2019

For #6803

@Gaurav0 Gaurav0 force-pushed the isreloading_computed branch from 69cee85 to e38f21f Compare December 2, 2019 19:47
runspired
runspired approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that whole computed is suspect but that's a refactor subject to another time, thanks!

@runspired runspired added 🏷️ chore This PR primarily refactors code or updates dependencies CI labels Dec 2, 2019
@runspired runspired merged commit 0e7c87a into emberjs:master Dec 2, 2019
@Gaurav0 Gaurav0 deleted the isreloading_computed branch December 2, 2019 21:59
@runspired runspired added Infra/CI/DX and removed CI labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
Infra/CI/DX 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gaurav0 @runspired