Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] RecordData is not a constructor #6985

Merged
merged 3 commits into from
Jan 22, 2020
Merged

[FIX] RecordData is not a constructor #6985

merged 3 commits into from
Jan 22, 2020

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jan 21, 2020 •
edited
Loading

Fixes issue spotted by partner tests for Storefront/Observer/Travis-web
This fix will need to be back ported alongside the fix for RecordData not implemented to 3.16 beta and 3.15 release

Also fixes (separate commit) lint issue that crept in and a lint perf issue where we would attempt lint the dists created for the performance checks.

@runspired runspired added the 🏷️ bug This PR primarily fixes a reported issue label Jan 21, 2020
@github-actions
Copy link

github-actions bot commented Jan 21, 2020 •
edited
Loading

Asset Size Report for f95c2ba

IE11 Builds

EmberData shrank by 696.0 B (127.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 175.72 KB -696.0 B (35.56 KB -127.0 B compressed)
    @ember-data/store 76.89 KB -675.0 B (15.56 KB -123.17 B compressed)
        @ember-data/store/-private 75.98 KB -675.0 B (15.38 KB -123.17 B compressed)
    ember-data 9.52 KB -21.0 B (1.93 KB -3.83 B compressed)
        ember-data/index 2.4 KB -21.0 B (497.46 B -3.83 B compressed)
Full Asset Analysis (IE11) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '175.72 KB' │
│ compressed │ '35.56 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '76.89 KB' │
│  compressed  │ '15.56 KB' │
│ % Of Library │   '43.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 75.98 KB  | 15.38 KB   | 98.8          | 43.2
	@ember-data/store/index                           | 936.00 B  | 189.43 B   | 1.2           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.96 KB' │
│  compressed  │ '5.25 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.96 KB  | 5.25 KB    | 100.0         | 14.8

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.83 KB' │
│  compressed  │ '4.22 KB'  │
│ % Of Library │   '11.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.75 KB   | 1.57 KB    | 37.2          | 4.4
	@ember-data/serializer/-private                   | 5.68 KB   | 1.15 KB    | 27.3          | 3.2
	@ember-data/serializer/json-api                   | 3.95 KB   | 817.84 B   | 18.9          | 2.2
	@ember-data/serializer/rest                       | 2.99 KB   | 620.31 B   | 14.4          | 1.7
	@ember-data/serializer/index                      | 258.00 B  | 52.21 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 43.51 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.45 KB' │
│  compressed  │ '3.13 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.12 KB   | 1.64 KB    | 52.6          | 4.6
	@ember-data/adapter/-private                      | 3.73 KB   | 773.31 B   | 24.2          | 2.1
	@ember-data/adapter/error                         | 1.95 KB   | 403.55 B   | 12.6          | 1.1
	@ember-data/adapter/json-api                      | 882.00 B  | 178.50 B   | 5.6           | 0.5
	@ember-data/adapter/index                         | 804.00 B  | 162.71 B   | 5.1           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.35 KB' │
│  compressed  │ '2.90 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 13.88 KB  | 2.81 KB    | 96.7          | 7.9
	@ember-data/model/index                           | 486.00 B  | 98.35 B    | 3.3           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.52 KB' │
│  compressed  │ '1.93 KB' │
│ % Of Library │   '5.4'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.40 KB   | 497.46 B   | 25.2          | 1.4
	ember-data/-private                               | 1.98 KB   | 410.64 B   | 20.8          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 246.30 B   | 12.5          | 0.7
	ember-data/setup-container                        | 503.00 B  | 101.80 B   | 5.2           | 0.3
	ember-data/relationships                          | 318.00 B  | 64.35 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 55.45 B    | 2.8           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 50.79 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 49.58 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.17 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.17 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 48.77 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 47.96 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 46.95 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 45.73 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 44.92 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 44.92 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.12 B    | 2.2           | 0.1
	ember-data/initialize-store-service               | 207.00 B  | 41.89 B    | 2.1           | 0.1
	ember-data/version                                | 162.00 B  | 32.78 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.41 KB' │
│  compressed  │ '1.70 KB' │
│ % Of Library │   '4.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.02 KB   | 624.96 B   | 35.9          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 325.84 B   | 18.7          | 0.9
	ember-inflector/index                             | 1.16 KB   | 240.23 B   | 13.8          | 0.7
	ember-inflector/lib/ext/string                    | 809.00 B  | 163.73 B   | 9.4           | 0.4
	ember-inflector/lib/helpers/pluralize             | 523.00 B  | 105.84 B   | 6.1           | 0.3
	ember-inflector/lib/system                        | 452.00 B  | 91.47 B    | 5.2           | 0.3
	ember-inflector/lib/system/string                 | 365.00 B  | 73.87 B    | 4.2           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 62.33 B    | 3.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 54.84 B    | 3.1           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.96 KB'  │
│  compressed  │ '612.82 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.47 KB   | 511.62 B   | 83.5          | 1.4
	@ember-data/debug/setup                           | 500.00 B  | 101.19 B   | 16.5          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.35 KB'  │
│  compressed  │ '278.88 B' │
│ % Of Library │   '0.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.35 KB   | 278.88 B   | 100.0         | 0.8

Modern Builds

EmberData shrank by 688.0 B (36.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 159.24 KB -688.0 B (34.1 KB -36.0 B compressed)
    @ember-data/store 67.81 KB -667.0 B (14.52 KB -34.9 B compressed)
        @ember-data/store/-private 66.9 KB -667.0 B (14.33 KB -34.9 B compressed)
    ember-data 9.52 KB -21.0 B (2.04 KB -1.1 B compressed)
        ember-data/index 2.4 KB -21.0 B (526.39 B -1.1 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '159.24 KB' │
│ compressed │ '34.10 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '67.81 KB' │
│  compressed  │ '14.52 KB' │
│ % Of Library │   '42.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 66.90 KB  | 14.33 KB   | 98.7          | 42.0
	@ember-data/store/index                           | 936.00 B  | 200.44 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.97 KB' │
│  compressed  │ '4.92 KB'  │
│ % Of Library │   '14.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.97 KB  | 4.92 KB    | 100.0         | 14.4

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.32 KB' │
│  compressed  │ '4.14 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.10 KB   | 1.52 KB    | 36.8          | 4.5
	@ember-data/serializer/-private                   | 5.36 KB   | 1.15 KB    | 27.8          | 3.4
	@ember-data/serializer/json-api                   | 3.71 KB   | 812.93 B   | 19.2          | 2.3
	@ember-data/serializer/rest                       | 2.70 KB   | 592.78 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 52.03 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.04 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.73 KB' │
│  compressed  │ '3.15 KB'  │
│ % Of Library │   '9.2'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.76 KB   | 1.66 KB    | 52.7          | 4.9
	@ember-data/adapter/-private                      | 3.54 KB   | 776.31 B   | 24.0          | 2.2
	@ember-data/adapter/error                         | 1.91 KB   | 419.52 B   | 13.0          | 1.2
	@ember-data/adapter/json-api                      | 830.00 B  | 177.74 B   | 5.5           | 0.5
	@ember-data/adapter/index                         | 719.00 B  | 153.97 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '13.25 KB' │
│  compressed  │ '2.84 KB'  │
│ % Of Library │   '8.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 12.77 KB  | 2.74 KB    | 96.4          | 8.0
	@ember-data/model/index                           | 486.00 B  | 104.07 B   | 3.6           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.52 KB' │
│  compressed  │ '2.04 KB' │
│ % Of Library │   '6.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.40 KB   | 526.39 B   | 25.2          | 1.5
	ember-data/-private                               | 1.98 KB   | 434.51 B   | 20.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 260.62 B   | 12.5          | 0.7
	ember-data/setup-container                        | 503.00 B  | 107.71 B   | 5.2           | 0.3
	ember-data/relationships                          | 318.00 B  | 68.10 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.67 B    | 2.8           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.75 B    | 2.6           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.46 B    | 2.5           | 0.2
	ember-data/serializers/json                       | 243.00 B  | 52.03 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.03 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.61 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.75 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.68 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.39 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 47.54 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.54 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.68 B    | 2.2           | 0.1
	ember-data/initialize-store-service               | 207.00 B  | 44.33 B    | 2.1           | 0.1
	ember-data/version                                | 162.00 B  | 34.69 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.69 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 604.55 B   | 34.9          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 344.78 B   | 19.9          | 1.0
	ember-inflector/index                             | 1.12 KB   | 245.84 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                    | 783.00 B  | 167.68 B   | 9.7           | 0.5
	ember-inflector/lib/system                        | 452.00 B  | 96.79 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 351.00 B  | 75.16 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 74.52 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 65.95 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 58.03 B    | 3.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '587.42 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.19 KB   | 480.55 B   | 81.8          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 106.86 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '230.85 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.05 KB   | 230.85 B   | 100.0         | 0.7

Modern Builds (No Rollup)

EmberData shrank by 128.0 B (-22.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 203.23 KB -128.0 B (38.5 KB +22.0 B compressed)
    @ember-data/store 99.65 KB -107.0 B (18.88 KB +18.39 B compressed)
        @ember-data/store/-private/system/core-store 17.19 KB +136.0 B (3.26 KB -23.38 B compressed)
        @ember-data/store/-private/system/ds-model-store 1.99 KB -243.0 B (385.27 B +41.77 B compressed)
    ember-data 9.78 KB -21.0 B (1.85 KB +3.61 B compressed)
        ember-data/index 2.4 KB -21.0 B (465.59 B +3.61 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '203.23 KB' │
│ compressed │ '38.50 KB'  │
│  packages  │      9      │
│  modules   │     145     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '99.65 KB' │
│  compressed  │ '18.88 KB' │
│ % Of Library │   '49.0'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.19 KB  | 3.26 KB    | 17.3          | 8.5
	@ember-data/store/-private/system/model/internal-model                             | 16.87 KB  | 3.20 KB    | 16.9          | 8.3
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.03 KB    | 5.5           | 2.7
	@ember-data/store/-private/system/fetch-manager                                    | 4.94 KB   | 958.46 B   | 5.0           | 2.4
	@ember-data/store/-private/system/store/finders                                    | 4.32 KB   | 837.61 B   | 4.3           | 2.1
	@ember-data/store/-private/index                                                   | 4.23 KB   | 819.80 B   | 4.2           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 3.58 KB   | 695.35 B   | 3.6           | 1.8
	@ember-data/store/-private/identifiers/cache                                       | 3.54 KB   | 686.83 B   | 3.6           | 1.7
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.43 KB   | 665.05 B   | 3.4           | 1.7
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.81 KB   | 545.90 B   | 2.8           | 1.4
	@ember-data/store/-private/system/snapshot                                         | 2.81 KB   | 544.39 B   | 2.8           | 1.4
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.04 KB   | 394.74 B   | 2.0           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.99 KB   | 385.27 B   | 2.0           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 367.28 B   | 1.9           | 0.9
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 285.45 B   | 1.5           | 0.7
	@ember-data/store/-private/system/relationship-meta                                | 1.47 KB   | 285.26 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/has-many                              | 1.38 KB   | 267.08 B   | 1.4           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.26 KB   | 244.35 B   | 1.3           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.15 KB   | 222.18 B   | 1.1           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 218.02 B   | 1.1           | 0.6
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 204.19 B   | 1.1           | 0.5
	@ember-data/store/index                                                            | 936.00 B  | 177.29 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 916.00 B  | 173.50 B   | 0.9           | 0.4
	@ember-data/store/-private/system/model/notify-changes                             | 862.00 B  | 163.27 B   | 0.8           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 855.00 B  | 161.95 B   | 0.8           | 0.4
	@ember-data/store/-private/system/references/record                                | 782.00 B  | 148.12 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 768.00 B  | 145.47 B   | 0.8           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 760.00 B  | 143.95 B   | 0.7           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 689.00 B  | 130.50 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references/reference                             | 686.00 B  | 129.94 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.27 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 105.31 B   | 0.5           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 95.84 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 499.00 B  | 94.52 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.24 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 85.23 B    | 0.4           | 0.2
	@ember-data/store/-private/system/diff-array                                       | 438.00 B  | 82.96 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 414.00 B  | 78.41 B    | 0.4           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 407.00 B  | 77.09 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/utils/symbol                              | 407.00 B  | 77.09 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 61.94 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.85 B    | 0.3           | 0.2
	@ember-data/store/-private/utils/promise-record                                    | 288.00 B  | 54.55 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/utils/brand                               | 286.00 B  | 54.17 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 268.00 B  | 50.76 B    | 0.3           | 0.1
	@ember-data/store/-private/system/ts-upgrade-map                                   | 248.00 B  | 46.97 B    | 0.2           | 0.1
	@ember-data/store/-private/system/record-data-for                                  | 235.00 B  | 44.51 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.15 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 210.00 B  | 39.77 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 36.55 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 35.98 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 150.00 B  | 28.41 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 144.00 B  | 27.27 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.56 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.18 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 17.99 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 17.99 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.04 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 16.85 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.10 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.10 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.34 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 14.77 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.20 B    | 0.1           | 0.0

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '26.48 KB' │
│  compressed  │ '5.01 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                                                      | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/relationships/state/relationship           | 8.30 KB   | 1.57 KB    | 31.4          | 4.1
	@ember-data/record-data/-private/record-data                                | 7.91 KB   | 1.50 KB    | 29.9          | 3.9
	@ember-data/record-data/-private/relationships/state/has-many               | 3.29 KB   | 638.53 B   | 12.4          | 1.6
	@ember-data/record-data/-private/relationships/state/belongs-to             | 3.22 KB   | 624.13 B   | 12.2          | 1.6
	@ember-data/record-data/-private/relationships/state/create                 | 1.15 KB   | 223.13 B   | 4.3           | 0.6
	@ember-data/record-data/-private/index                                      | 1023.00 B | 193.77 B   | 3.8           | 0.5
	@ember-data/record-data/-private/record-data-for                            | 481.00 B  | 91.11 B    | 1.8           | 0.2
	@ember-data/record-data/-private/ordered-set                                | 407.00 B  | 77.09 B    | 1.5           | 0.2
	@ember-data/record-data/-private/coerce-id                                  | 406.00 B  | 76.90 B    | 1.5           | 0.2
	@ember-data/record-data/-private/normalize-link                             | 249.00 B  | 47.16 B    | 0.9           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data     | 100.00 B  | 18.94 B    | 0.4           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.71 KB' │
│  compressed  │ '4.11 KB'  │
│ % Of Library │   '10.7'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.10 KB   | 1.35 KB    | 32.7          | 3.5
	@ember-data/serializer/-private/embedded-records-mixin     | 4.29 KB   | 831.35 B   | 19.7          | 2.1
	@ember-data/serializer/json-api                            | 3.71 KB   | 719.03 B   | 17.1          | 1.8
	@ember-data/serializer/rest                                | 2.70 KB   | 524.31 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 229.19 B   | 5.4           | 0.6
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 99.06 B    | 2.4           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 92.81 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 84.48 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 66.48 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 54.17 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 46.02 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 45.83 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.72 B    | 1.0           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.21 KB' │
│  compressed  │ '3.26 KB'  │
│ % Of Library │   '8.5'    │
└──────────────┴────────────┘
	Module                                                   | Bytes     | Compressed | % of Package  | % Of Library
	------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                         | 6.28 KB   | 1.19 KB    | 36.5          | 3.1
	@ember-data/model/-private/system/many-array             | 2.24 KB   | 434.33 B   | 13.0          | 1.1
	@ember-data/model/-private/errors                        | 1.92 KB   | 372.77 B   | 11.2          | 0.9
	@ember-data/model/-private/index                         | 1.29 KB   | 250.22 B   | 7.5           | 0.6
	@ember-data/model/-private/system/relationships/ext      | 1.19 KB   | 230.14 B   | 6.9           | 0.6
	@ember-data/model/-private/attr                          | 743.00 B  | 140.73 B   | 4.2           | 0.4
	@ember-data/model/-private/belongs-to                    | 663.00 B  | 125.58 B   | 3.8           | 0.3
	@ember-data/model/-private/has-many                      | 626.00 B  | 118.57 B   | 3.6           | 0.3
	@ember-data/model/-private/system/promise-many-array     | 611.00 B  | 115.73 B   | 3.5           | 0.3
	@ember-data/model/index                                  | 486.00 B  | 92.05 B    | 2.8           | 0.2
	@ember-data/model/-private/util                          | 443.00 B  | 83.91 B    | 2.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to     | 410.00 B  | 77.66 B    | 2.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin        | 408.00 B  | 77.28 B    | 2.3           | 0.2

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '16.77 KB' │
│  compressed  │ '3.18 KB'  │
│ % Of Library │   '8.3'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.76 KB   | 1.47 KB    | 46.3          | 3.8
	@ember-data/adapter/error                                     | 1.91 KB   | 371.07 B   | 11.4          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.80 KB   | 349.85 B   | 10.8          | 0.9
	@ember-data/adapter/-private/index                            | 1.03 KB   | 200.02 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 830.00 B  | 157.21 B   | 4.8           | 0.4
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 150.01 B   | 4.6           | 0.4
	@ember-data/adapter/index                                     | 719.00 B  | 136.19 B   | 4.2           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 523.00 B  | 99.06 B    | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 90.92 B    | 2.8           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 85.99 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 65.72 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 217.00 B  | 41.10 B    | 1.3           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.78 KB' │
│  compressed  │ '1.85 KB' │
│ % Of Library │   '4.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.40 KB   | 465.59 B   | 24.5          | 1.2
	ember-data/-private/index                         | 1.93 KB   | 373.91 B   | 19.7          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 230.52 B   | 12.2          | 0.6
	ember-data/setup-container                        | 503.00 B  | 95.27 B    | 5.0           | 0.2
	ember-data/-private/core                          | 321.00 B  | 60.80 B    | 3.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.23 B    | 3.2           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.90 B    | 2.7           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.54 B    | 2.5           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.40 B    | 2.4           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.02 B    | 2.4           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.02 B    | 2.4           | 0.1
	ember-data/transform                              | 241.00 B  | 45.64 B    | 2.4           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.89 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.94 B    | 2.3           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.80 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.05 B    | 2.2           | 0.1
	ember-data/store                                  | 222.00 B  | 42.05 B    | 2.2           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.29 B    | 2.2           | 0.1
	ember-data/initialize-store-service               | 207.00 B  | 39.20 B    | 2.1           | 0.1
	ember-data/version                                | 162.00 B  | 30.68 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.50 KB' │
│ % Of Library │   '3.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.76 KB   | 534.72 B   | 34.9          | 1.4
	ember-inflector/lib/system/inflections            | 1.57 KB   | 304.96 B   | 19.9          | 0.8
	ember-inflector/index                             | 1.12 KB   | 217.45 B   | 14.2          | 0.6
	ember-inflector/lib/ext/string                    | 783.00 B  | 148.31 B   | 9.7           | 0.4
	ember-inflector/lib/system                        | 452.00 B  | 85.61 B    | 5.6           | 0.2
	ember-inflector/lib/system/string                 | 351.00 B  | 66.48 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 65.91 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 58.34 B    | 3.8           | 0.1
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 51.33 B    | 3.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '519.57 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.19 KB   | 425.05 B   | 81.8          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 94.51 B    | 18.2          | 0.2

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '204.19 B' │
│ % Of Library │   '0.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.05 KB   | 204.19 B   | 100.0         | 0.5

@github-actions
Copy link

github-actions bot commented Jan 21, 2020 •
edited
Loading

Performance Report for f95c2ba

Relationship Analysis 
                        -------------

__/\\\\\\\\\\\\\____/\\\\____________/\\\\____/\\\\\\\\\_____
 _\/\\\/////////\\\_\/\\\\\\________/\\\\\\__/\\\///////\\\___
  _\/\\\_______\/\\\_\/\\\//\\\____/\\\//\\\_\///______\//\\\__
   _\/\\\\\\\\\\\\\/__\/\\\\///\\\/\\\/_\/\\\___________/\\\/___
    _\/\\\/////////____\/\\\__\///\\\/___\/\\\________/\\\//_____
     _\/\\\_____________\/\\\____\///_____\/\\\_____/\\\//________
      _\/\\\_____________\/\\\_____________\/\\\___/\\\/___________
       _\/\\\_____________\/\\\_____________\/\\\__/\\\\\\\\\\\\\\\_
        _\///______________\///______________\///__\///////////////__


                          Runtime Edition

        PM2 is a Production Process Manager for Node.js applications
                     with a built-in Load Balancer.

                Start and Daemonize any application:
                $ pm2 start app.js

                Load Balance 4 instances of api.js:
                $ pm2 start api.js -i 4

                Monitor in production:
                $ pm2 monitor

                Make pm2 auto-boot at server restart:
                $ pm2 startup

                To go further checkout:
                http://pm2.io/


                        -------------

[PM2] Spawning PM2 daemon with pm2_home=/home/runner/.pm2
[PM2] PM2 Successfully daemonized
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name       │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control    │ default     │ N/A     │ fork    │ 2980     │ 0s     │ 0    │ online    │ 0%       │ 29.1mb   │ runner   │ disabled │
└─────┴────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬───────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name          │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼───────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control       │ default     │ N/A     │ fork    │ 2980     │ 0s     │ 0    │ online    │ 0%       │ 64.4mb   │ runner   │ disabled │
│ 1   │ experiment    │ default     │ N/A     │ fork    │ 3008     │ 0s     │ 0    │ online    │ 0%       │ 25.2mb   │ runner   │ disabled │
└─────┴───────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
Computing results...


┌───────────────────────────────────────────────────────────────────────┐
│ Initial Render : duration                                             │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1448ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1950ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1649ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1676ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1722ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1755ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1778ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1454ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1877ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1611ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1678ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1724ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1751ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1789ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 1ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -21ms to 25ms                │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▁▁▁▁█▇█▁▁▁▁                 │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▂▁▁▂▅█▅▁▁▁▁                 │
└────────────────────────────────────────┴──────────────────────────────┘


┌───────────────────────────────────────────────────────────────────────┐
│ Sub Phase of Duration : start-find-all                                │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1020ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1446ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1142ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1176ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1214ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1240ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1253ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1017ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1342ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1138ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1173ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1214ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1237ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1262ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ -1ms                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -18ms to 16ms                │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▁▁▄█▂▁▁▁                    │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▂▁▁▆█▃▁▁▁                    │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : start-outer-materialization                   │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 411ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 545ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 451ms                  │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 471ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 484ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 494ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 510ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 416ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 524ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 443ms                  │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 475ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 487ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 502ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 510ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 4ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -4ms to 12ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▂▁▁▄▃▇█▆▂▃▁▁▁               │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▁▂▁▁▁▃█▄▅▂▂▁▁               │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : stop-outer-materialization                    │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 0ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 0ms to 0ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ true                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁█▇▂▁▂▁▁▁                    │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▄█▄▂▁▁▁▁                    │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : end-find-all                                  │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 17ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 36ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 20ms                   │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 20ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 21ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 22ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 31ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 18ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 23ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 19ms                   │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 20ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 21ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 22ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 23ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 0ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -1ms to 0ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▂█▂▁▁▁▁▁▁▁                  │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▅█▄▁▁▁▁▁▁▁                  │
└────────────────────────────────────────┴──────────────────────────────┘

    =========== Benchmark Results Summary ===========    
Red color means there was a regression. Green color means there was an improvement. You can view more statistical details about the phases above.

duration phase has no difference. 

start-find-all phase has no difference. 

start-outer-materialization phase has no difference. 

stop-outer-materialization phase has no difference. 

end-find-all phase has an estimated difference of -0ms. 

[PM2] [v] Modules Stopped
[PM2] Applying action deleteProcessId on app [all](ids: [ 0, 1 ])
[PM2] [control](0) ✓
[PM2] [experiment](1) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] PM2 Daemon Stopped

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release labels Jan 21, 2020
@runspired
fix lint issue
2a1c1e9 
ignore other dist output dirs too
@runspired runspired force-pushed the fix/record-data-fix branch 2 times, most recently from feacd7a to ae8a5c1 Compare January 22, 2020 01:24
@runspired runspired force-pushed the fix/record-data-fix branch from ae8a5c1 to 46085de Compare January 22, 2020 01:49
@runspired @hjdivad
Update packages/store/addon/-private/system/core-store.ts
f95c2ba 
Co-Authored-By: David J. Hamilton <dhamilton@linkedin.com>
@hjdivad
Copy link
Member

hjdivad commented Jan 22, 2020

Tests red due to #6961 canary issues that don't impede release but otherwise 🍏

@hjdivad hjdivad merged commit 88d35d9 into master Jan 22, 2020
@hjdivad hjdivad deleted the fix/record-data-fix branch January 22, 2020 18:56
This was referenced Jan 24, 2020
Merged
Merged
@hjdivad hjdivad removed 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release labels Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjdivad hjdivad hjdivad left review comments

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runspired @hjdivad @rwjblue