[ON_HOLD] feat: custom decorators #7477
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Ember to more easily remove support for some aspects of ComputedProperty, computed.meta etc. while also giving us better access to the schema at runtime. This is the first step towards being able to compile schema at build time, some deprecations are necessary to take that step.
In theory, this should provide a significant performance boost for accessing static schema and/or accessing a value. However, do to the complexity of also supporting sync-observers and async-proxies there are some caveats that may negate these wins. Benchmarking is needed.
Edit Going to put this on hold for now because (1) the various workarounds for
reopen
andsync observers
seem to nuke perf in addition to adding a lot more size and complexity and (2) there's no clear path forward for this issue: emberjs/ember.js#19504