fix tests #7703

snewcomer · 2021-09-11T14:58:18Z

further cleanup of #7393

github-actions · 2021-09-11T15:03:28Z

Asset Size Report for 8bd7d39

IE11 Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (IE11)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '198.36 KB' │
│ compressed │ '40.83 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '81.83 KB' │
│  compressed  │ '16.85 KB' │
│ % Of Library │   '41.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 80.92 KB  | 16.66 KB   | 98.9          | 40.8
	@ember-data/store/index                           | 936.00 B  | 192.67 B   | 1.1           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.11 KB' │
│  compressed  │ '6.61 KB'  │
│ % Of Library │   '16.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 31.63 KB  | 6.51 KB    | 98.5          | 15.9
	@ember-data/model/index                           | 486.00 B  | 100.04 B   | 1.5           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.74 KB' │
│  compressed  │ '5.30 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.74 KB  | 5.30 KB    | 100.0         | 13.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.13 KB' │
│  compressed  │ '4.35 KB'  │
│ % Of Library │   '10.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.84 KB   | 1.61 KB    | 37.1          | 4.0
	@ember-data/serializer/-private                   | 5.81 KB   | 1.20 KB    | 27.5          | 2.9
	@ember-data/serializer/json-api                   | 3.96 KB   | 834.32 B   | 18.7          | 2.0
	@ember-data/serializer/rest                       | 3.04 KB   | 641.85 B   | 14.4          | 1.5
	@ember-data/serializer/index                      | 273.00 B  | 56.19 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 44.25 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.93 KB' │
│  compressed  │ '3.69 KB'  │
│ % Of Library │   '9.0'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 9.23 KB   | 1.90 KB    | 51.5          | 4.7
	@ember-data/adapter/-private                      | 3.84 KB   | 809.41 B   | 21.4          | 1.9
	@ember-data/adapter/error                         | 1.98 KB   | 416.64 B   | 11.0          | 1.0
	@ember-data/adapter/index                         | 1.51 KB   | 318.45 B   | 8.4           | 0.8
	@ember-data/adapter/json-api                      | 1.37 KB   | 288.81 B   | 7.6           | 0.7

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.49 KB' │
│  compressed  │ '1.95 KB' │
│ % Of Library │   '4.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 509.28 B   | 25.5          | 1.2
	ember-data/-private                               | 2.12 KB   | 447.11 B   | 22.4          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 250.52 B   | 12.5          | 0.6
	ember-data/setup-container                        | 520.00 B  | 107.04 B   | 5.4           | 0.3
	ember-data/relationships                          | 318.00 B  | 65.46 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 56.40 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.66 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.43 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 50.02 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 50.02 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 49.61 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.78 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.75 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.52 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 45.69 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.69 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.87 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 33.14 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.07 KB' │
│  compressed  │ '1.46 KB' │
│ % Of Library │   '3.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 655.43 B   | 44.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 334.92 B   | 22.5          | 0.8
	ember-inflector/lib/helpers/pluralize             | 506.00 B  | 104.16 B   | 7.0           | 0.2
	ember-inflector/index                             | 473.00 B  | 97.36 B    | 6.5           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 96.95 B    | 6.5           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 72.46 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 332.00 B  | 68.34 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.93 B    | 4.1           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '3.07 KB'  │
│  compressed  │ '646.79 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.58 KB   | 543.86 B   | 84.1          | 1.3
	@ember-data/debug/setup                           | 500.00 B  | 102.92 B   | 15.9          | 0.2

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.19 KB' │
│ compressed │ '39.00 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.24 KB' │
│  compressed  │ '15.72 KB' │
│ % Of Library │   '40.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.32 KB  | 15.52 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 203.73 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.56 KB' │
│  compressed  │ '6.22 KB'  │
│ % Of Library │   '15.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.08 KB  | 6.11 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 105.78 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.77 KB' │
│  compressed  │ '5.17 KB'  │
│ % Of Library │   '13.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.77 KB  | 5.17 KB    | 100.0         | 13.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.65 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.21 KB   | 1.57 KB    | 36.7          | 4.0
	@ember-data/serializer/-private                   | 5.49 KB   | 1.20 KB    | 27.9          | 3.1
	@ember-data/serializer/json-api                   | 3.73 KB   | 830.61 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.76 KB   | 615.56 B   | 14.1          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 56.15 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.79 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.98 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.13 KB   | 1.77 KB    | 50.8          | 4.5
	@ember-data/adapter/-private                      | 3.77 KB   | 840.62 B   | 23.6          | 2.1
	@ember-data/adapter/error                         | 1.94 KB   | 432.93 B   | 12.2          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 244.87 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.04 KB   | 232.46 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.49 KB' │
│  compressed  │ '2.07 KB' │
│ % Of Library │   '5.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 538.50 B   | 25.5          | 1.3
	ember-data/-private                               | 2.12 KB   | 472.77 B   | 22.4          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 264.90 B   | 12.5          | 0.7
	ember-data/setup-container                        | 520.00 B  | 113.18 B   | 5.4           | 0.3
	ember-data/relationships                          | 318.00 B  | 69.21 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.64 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 54.63 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.32 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.89 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.89 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 52.45 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.58 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.49 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.19 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 48.32 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.32 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.45 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 35.04 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.46 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 641.90 B   | 43.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 354.14 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 102.95 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.52 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 81.18 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 76.61 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.21 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.42 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '626.01 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 517.39 B   | 82.6          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 108.61 B   | 17.4          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.79 KB' │
│ compressed │ '42.41 KB'  │
│  packages  │      8      │
│  modules   │     149     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.93 KB' │
│  compressed  │ '18.81 KB' │
│ % Of Library │   '44.4'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.37 KB  | 3.34 KB    | 17.7          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.45 KB  | 2.78 KB    | 14.8          | 6.5
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.09 KB   | 1001.53 B  | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.57 KB   | 899.73 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.19 KB   | 823.47 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.98 KB   | 783.32 B   | 4.1           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 702.07 B   | 3.6           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.41 KB   | 669.99 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 610.64 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.82 KB   | 555.32 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 448.71 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.96 KB   | 385.70 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 370.91 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 301.38 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.51 KB   | 297.54 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 260.08 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 259.12 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 224.35 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 207.06 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 982.00 B  | 188.62 B   | 1.0           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 967.00 B  | 185.74 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 179.79 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 934.00 B  | 179.40 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 170.18 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 798.00 B  | 153.28 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 144.64 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 133.88 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 695.00 B  | 133.49 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 607.00 B  | 116.59 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.86 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 101.22 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.27 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.54 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.43 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.83 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.48 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 390.00 B  | 74.91 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.81 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.69 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.70 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 269.00 B  | 51.67 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.36 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.25 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.72 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.33 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.46 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 32.07 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.88 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.88 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.88 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.92 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.73 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.73 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.96 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.96 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 29.19 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.62 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 28.04 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 28.04 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.67 KB' │
│  compressed  │ '6.27 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.89 KB   | 1.90 KB    | 30.3          | 4.5
	@ember-data/model/-private/record-state                               | 6.20 KB   | 1.19 KB    | 19.0          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 748.17 B   | 11.6          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.85 KB   | 560.50 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.08 KB   | 409.91 B   | 6.4           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 279.67 B   | 4.4           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 246.44 B   | 3.8           | 0.6
	@ember-data/model/-private/attr                                       | 857.00 B  | 164.61 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 162.31 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 687.00 B  | 131.96 B   | 2.1           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 124.47 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.35 B    | 1.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.86 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.90 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.13 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 431.00 B  | 82.78 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.84 KB' │
│  compressed  │ '5.92 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.21 KB   | 1.58 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.86 KB   | 955.82 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.14 KB   | 617.55 B   | 10.2          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.83 KB   | 556.47 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.01 KB   | 395.31 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.92 KB   | 378.21 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.50 KB   | 295.62 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.05 KB   | 206.49 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.80 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 187.66 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 788.00 B  | 151.36 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 132.92 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 667.00 B  | 128.12 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.98 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.28 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.71 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.84 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.81 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.08 KB' │
│  compressed  │ '4.24 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.21 KB   | 1.39 KB    | 32.7          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.39 KB   | 863.04 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.73 KB   | 732.99 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.76 KB   | 543.21 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 232.42 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.46 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 507.00 B  | 97.38 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.67 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 368.00 B  | 70.68 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 58.20 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.55 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 257.00 B  | 49.36 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.29 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.11 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.13 KB   | 1.56 KB    | 44.9          | 3.7
	@ember-data/adapter/error                                     | 1.94 KB   | 382.05 B   | 10.7          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 380.33 B   | 10.7          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 216.09 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 1.04 KB   | 205.14 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 202.84 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 152.13 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 566.00 B  | 108.72 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.20 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.20 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.65 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.64 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.23 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.65 KB' │
│  compressed  │ '1.85 KB' │
│ % Of Library │   '4.4'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 475.21 B   | 25.0          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 379.17 B   | 20.0          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 233.76 B   | 12.3          | 0.5
	ember-data/setup-container                        | 520.00 B  | 99.88 B    | 5.3           | 0.2
	ember-data/-private/core                          | 366.00 B  | 70.30 B    | 3.7           | 0.2
	ember-data/relationships                          | 318.00 B  | 61.08 B    | 3.2           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.63 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.21 B    | 2.5           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.06 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.67 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.67 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.29 B    | 2.4           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.52 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.56 B    | 2.3           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.41 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.64 B    | 2.2           | 0.1
	ember-data/store                                  | 222.00 B  | 42.64 B    | 2.2           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.87 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.92 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 566.45 B   | 43.0          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 312.52 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.85 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.47 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.64 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.61 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.08 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.85 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '552.43 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 456.58 B   | 82.6          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.84 B    | 17.4          | 0.2

github-actions · 2021-09-11T15:34:27Z

Performance Report for 8bd7d39

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-32ms to 24ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-19ms to 7ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-20ms to 18ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-6ms to 15ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-5ms to 4ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-28ms to 31ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-21ms to 5ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-15ms to 22ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-8ms to 10ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 2ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-64ms to 17ms]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -15ms [-28ms to -1ms] OR -1.97% [-3.75% to -0.16%]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-26ms to 13ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-11ms to 17ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 2ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-7ms to 36ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-5ms to 23ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-4ms to 17ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-5ms to 4ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-2ms to 2ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-39ms to 10ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-12ms to 12ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-31ms to 6ms]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -4ms [-6ms to -1ms] OR -3.25% [-5.55% to -1.03%]

snewcomer · 2021-09-12T04:48:48Z

packages/-ember-data/tests/integration/store-test.js

-    assert.ok(true, 'we made it to the end');
-    await requestPromise;
-    assert.ok(false, 'we should never make it here');
+    assert.equal(result.data.type, 'car', 'we made it to the end');
  });


This test is now failing on the main branch (see here where tests never finish). I rewrote it a little bit but the main issue was await requestPromise. On first glance, I can't tell what is going wrong here.

Since this was failing on 3.20 (last 3.20 release was https://github.com/emberjs/ember.js/tree/v3.20.7) something has "changed" since the last PRs a week ago. In any case, I distilled the test down a bit.

Ha, interesting, it seems like we are asserting that the promise never finishes, it makes sense it would hang the test. We can rewrite this as .then and not hang on it, or just rely on the store.push

Fixed with .then! Thank you!

snewcomer · 2021-09-12T04:51:08Z

packages/-ember-data/tests/integration/store-test.js

@@ -165,7 +164,8 @@ module('integration/store - destroy', function (hooks) {

      throw new Error("We shouldn't be pushing data into the store when it is destroyed");
    };
-    let requestPromise = store.findRecord('car', '1');
+
+    store.findRecord('car', '1');

    await nextPromise;


I thought I was reading this right but now I'm questioning myself. I wouldn't think we would advance from this line because we have yet to resolve the promise. I thought it would just hang here.

It gets resolved on line 143 no?

Here is a plan TS example. We haven't resolved yet as of our await nextPromise. Clearly a gap in my knowledge somewhere 😆

I missed that store.findRecord would batch multiple if necessary. As a result, nextPromise is undefined here.

sandstrom · 2021-09-15T15:22:43Z

@snewcomer Any plans on upping the tiers on your sponsor page?

runspired has higher-tiers available (https://github.com/sponsors/runspired), and would be happy to up our sponsorship for you as well. May I suggest a $100 tier?

igorT · 2021-09-16T15:05:21Z

packages/canary-features/addon/default-features.ts

@@ -173,10 +173,8 @@ export default {
  SAMPLE_FEATURE_FLAG: null,
  RECORD_DATA_ERRORS: true,
  RECORD_DATA_STATE: true,
-  IDENTIFIERS: true,


I think we might want to keep these, in case someone was reading them and branching code off of it, removing them would break. Do you think there is a downside in not GCing them?

I only thought to commit these for clarity of the codebase. Certainly if someone was relying on a forked version of e-d, but is it something we expect users to read? And if they do, then it is expected they could be removed at any point? As long as we get the tests passing, I'm ok to do whatever you think is best 👍

* chore(deps): bump broccoli-rollup from 4.1.1 to 5.0.0 (#7559) Bumps [broccoli-rollup](https://github.com/chadhietala/broccoli-rollup) from 4.1.1 to 5.0.0. - [Release notes](https://github.com/chadhietala/broccoli-rollup/releases) - [Changelog](https://github.com/chadhietala/broccoli-rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/chadhietala/broccoli-rollup/commits/v5.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * CI timeouts testing bump (#7734) * Fix hanging store.destroy testt (#7703) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…7761) * Cherry pick: chore(deps): bump broccoli-rollup from 4.1.1 to 5.0.0 * CI timeouts testing bump (#7734) * Fix hanging store.destroy testt (#7703) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

snewcomer added 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality labels Sep 11, 2021

snewcomer self-assigned this Sep 11, 2021

[cleanup]: rm unused flags

198eba7

snewcomer force-pushed the sn/rm-unused-flags branch from 6a2c991 to 509d9ce Compare September 11, 2021 15:23

tmp remove

d81f022

snewcomer force-pushed the sn/rm-unused-flags branch from 2adc748 to d81f022 Compare September 11, 2021 20:15

fix stuck test. requestPromise is already resolved in previous steps

4f5fdca

snewcomer force-pushed the sn/rm-unused-flags branch from 54ac421 to 4f5fdca Compare September 12, 2021 00:27

snewcomer requested a review from igorT September 12, 2021 04:24

improve test slightly

2b22be8

snewcomer commented Sep 12, 2021

View reviewed changes

snewcomer changed the title ~~[cleanup]: rm unused flags~~ [cleanup]: rm unused flags and fix tests Sep 12, 2021

igorT reviewed Sep 16, 2021

View reviewed changes

snewcomer added 2 commits September 16, 2021 19:34

.then on requestPromise to ensure test doesnt hang

af375be

add back for libraries

8bd7d39

snewcomer requested a review from igorT September 17, 2021 00:58

snewcomer changed the title ~~[cleanup]: rm unused flags and fix tests~~ fix tests Sep 17, 2021

igorT merged commit 0b0ff4e into master Sep 17, 2021

igorT deleted the sn/rm-unused-flags branch September 17, 2021 15:26

snewcomer added a commit that referenced this pull request Nov 21, 2021

Fix hanging store.destroy testt (#7703)

bab5718

snewcomer added a commit that referenced this pull request Nov 21, 2021

Fix hanging store.destroy testt (#7703)

8729912

snewcomer added a commit that referenced this pull request Nov 21, 2021

Fix hanging store.destroy testt (#7703)

3f08041

igorT pushed a commit that referenced this pull request Nov 23, 2021

Fix hanging store.destroy testt (#7703)

4e53272

igorT pushed a commit that referenced this pull request Nov 23, 2021

Fix hanging store.destroy testt (#7703)

0fc9708

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix tests #7703

fix tests #7703

snewcomer commented Sep 11, 2021

github-actions bot commented Sep 11, 2021 •

edited

Loading

github-actions bot commented Sep 11, 2021 •

edited

Loading

snewcomer Sep 12, 2021 •

edited

Loading

snewcomer Sep 12, 2021

igorT Sep 16, 2021

snewcomer Sep 17, 2021

snewcomer Sep 12, 2021

igorT Sep 16, 2021

snewcomer Sep 17, 2021 •

edited

Loading

snewcomer Sep 17, 2021

sandstrom commented Sep 15, 2021

igorT Sep 16, 2021

snewcomer Sep 17, 2021

fix tests #7703

fix tests #7703

Conversation

snewcomer commented Sep 11, 2021

github-actions bot commented Sep 11, 2021 • edited Loading

github-actions bot commented Sep 11, 2021 • edited Loading

snewcomer Sep 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snewcomer Sep 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sandstrom commented Sep 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 11, 2021 •

edited

Loading

github-actions bot commented Sep 11, 2021 •

edited

Loading

snewcomer Sep 12, 2021 •

edited

Loading

snewcomer Sep 17, 2021 •

edited

Loading