Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup]: Remove implicit store injection slated for Ember v4.0.0 (#… #7736

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

igorT
Copy link
Member

@igorT igorT commented Nov 3, 2021

…7667)

Backport of #7667

@igorT igorT added 🏷️ chore This PR primarily refactors code or updates dependencies backport-beta PR targets the beta branch labels Nov 3, 2021
@igorT igorT requested a review from snewcomer November 3, 2021 22:43
@igorT igorT added 🏷️ cleanup This PR primarily removes deprecated functionality and removed 🏷️ chore This PR primarily refactors code or updates dependencies labels Nov 3, 2021
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the same timeout bugs :(. Not sure if we want to back port #7734 as well

@igorT
Copy link
Member Author

igorT commented Nov 4, 2021

This is failing due to timeouts for ember-release channels tests, but going to merge to unblock @chancancode and ember-cli beta. Looking into failures separately.

@igorT igorT merged commit c178c64 into beta Nov 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the backport-store-inject branch November 4, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-beta PR targets the beta branch 🏷️ cleanup This PR primarily removes deprecated functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants