Place store on Ember.Route to maintain implicit record loading #7765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
added
🏷️ chore
snewcomer
force-pushed
the
sn/inject-store-route
branch
from
4d4d9be to
3a69d25
Compare
snewcomer
added
🎯 beta
snewcomer
force-pushed
the
sn/inject-store-route
branch
from
3f08041 to
ec86df7
Compare
mixonic
reviewed
Nov 23, 2021
| @@ -46,6 +51,22 @@ function initializeStore(application) { | |||
| } | |||
| } | |||
|
|
|||
| // Implicit injection was removed. This is a replacement for Ember Route implicit store | |||
| // https://github.com/emberjs/rfcs/pull/774 | |||
| Object.defineProperty(Route, 'store', { | |||
There was a problem hiding this comment.
This would define a property on the Route class itself, right? Why not use reopen?
There was a problem hiding this comment.
You were right. I has thought defineProperty and reopen would be equivalent but turns out I was wrong.
There was a problem hiding this comment.
I'm guessing this has something to do with EmberObject. But overall I was trying the other way to avoid the reopen deprecation
|
Once we fix the implicit injection deprecation for 3.28 do we still need to do this? |
snewcomer
force-pushed
the
sn/inject-store-route
branch
from
0770a28 to
25af494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref emberjs/rfcs#774
Fix #7744