Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waiter should be always on #7901

Merged
merged 3 commits into from
Jul 23, 2022
Merged

fix: waiter should be always on #7901

merged 3 commits into from
Jul 23, 2022

Conversation

runspired
Copy link
Contributor

fixes #7821 #6720

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue 🎯 canary PR is targeting canary (default) labels Feb 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Asset Size Report for f82496f

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '178.00 KB' │
│ compressed │ '37.48 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '69.74 KB' │
│  compressed  │ '14.68 KB' │
│ % Of Library │   '39.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 68.82 KB  | 14.49 KB   | 98.7          | 38.7
	@ember-data/store/index                           | 936.00 B  | 197.07 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.11 KB' │
│  compressed  │ '6.34 KB'  │
│ % Of Library │   '16.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 29.63 KB  | 6.24 KB    | 98.4          | 16.6
	@ember-data/model/index                           | 486.00 B  | 102.32 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.38 KB' │
│  compressed  │ '5.13 KB'  │
│ % Of Library │   '13.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.38 KB  | 5.13 KB    | 100.0         | 13.7

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.77 KB' │
│  compressed  │ '4.16 KB'  │
│ % Of Library │   '11.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.22 KB   | 1.52 KB    | 36.5          | 4.1
	@ember-data/serializer/-private                   | 5.53 KB   | 1.16 KB    | 28.0          | 3.1
	@ember-data/serializer/json-api                   | 3.71 KB   | 799.87 B   | 18.8          | 2.1
	@ember-data/serializer/rest                       | 2.84 KB   | 613.32 B   | 14.4          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 54.32 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.26 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.71 KB' │
│  compressed  │ '3.31 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.66 KB    | 50.1          | 4.4
	@ember-data/adapter/-private                      | 3.77 KB   | 813.34 B   | 24.0          | 2.1
	@ember-data/adapter/error                         | 1.99 KB   | 429.30 B   | 12.7          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 223.39 B   | 6.6           | 0.6
	@ember-data/adapter/json-api                      | 1.03 KB   | 222.96 B   | 6.6           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.77 KB' │
│  compressed  │ '1.85 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.14 KB   | 461.94 B   | 24.4          | 1.2
	ember-data/-private                               | 1.83 KB   | 393.72 B   | 20.8          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 256.23 B   | 13.5          | 0.7
	ember-data/setup-container                        | 368.00 B  | 77.48 B    | 4.1           | 0.2
	ember-data/relationships                          | 318.00 B  | 66.95 B    | 3.5           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 57.69 B    | 3.1           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 52.84 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 51.58 B    | 2.7           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.16 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.16 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 50.74 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 49.89 B    | 2.6           | 0.1
	ember-data/serializer                             | 232.00 B  | 48.84 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.58 B    | 2.5           | 0.1
	ember-data/model                                  | 222.00 B  | 46.74 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 46.74 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 45.89 B    | 2.4           | 0.1
	ember-data/version                                | 161.00 B  | 33.89 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.40 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 638.80 B   | 44.4          | 1.7
	ember-inflector/lib/system/inflections            | 1.59 KB   | 342.56 B   | 23.8          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 99.16 B    | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 79.79 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 77.69 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 69.90 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 66.95 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.32 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.85 KB'  │
│  compressed  │ '615.01 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.36 KB   | 508.68 B   | 82.7          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 106.32 B   | 17.3          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

Performance Report for 870c23e

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-42ms to 18ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-17ms to 5ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-19ms to 9ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-8ms to 6ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-5ms to 6ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-24ms to 20ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 14ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-19ms to 7ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-3ms to 7ms]
✅ Phase [end-unload-records] => [Test End]
phase estimated improvement -1ms [-2ms to 0ms] OR -1.37% [-2.33% to -0.44%]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-29ms to 34ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 24ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-22ms to 17ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-17ms to 1ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 2ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-24ms to 13ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-23ms to 8ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-10ms to 7ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 6ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-2ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 40ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 20ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-6ms to 22ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-3ms to 1ms]

@runspired runspired force-pushed the runspired/fix-waiter branch from 870c23e to e5a8b0e Compare July 23, 2022 08:53
@runspired runspired merged commit 4af91e4 into master Jul 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the runspired/fix-waiter branch July 23, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store in acceptance tests destroyed before Route#deactivate is run
2 participants