Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for async hasMany does not trigger relationship fetch #7902

Merged
merged 6 commits into from
Apr 30, 2022

Conversation

snewcomer
Copy link
Contributor

close #7844

@snewcomer snewcomer added the Bug label Feb 24, 2022
@snewcomer snewcomer self-assigned this Feb 24, 2022
@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Asset Size Report for f710c3a

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Performance Report for bb6a415

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-20ms to 30ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-10ms to 10ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-11ms to 9ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-3ms to 8ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-5ms to 6ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-15ms to 26ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 14ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-11ms to 13ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [0ms to 6ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-30ms to 16ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-20ms to 8ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-12ms to 11ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-6ms to 5ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-16ms to 23ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-14ms to 21ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-10ms to 6ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-2ms to 5ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-22ms to 14ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 14ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-16ms to 5ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-1ms to 3ms]

@snewcomer snewcomer added 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Feb 25, 2022
@snewcomer snewcomer changed the title bug: new records are improperly reloaded when relationships are set example: new records are improperly reloaded when relationships are set Feb 26, 2022
@snewcomer snewcomer changed the title example: new records are improperly reloaded when relationships are set test for async hasMany does not trigger relationship fetch Apr 24, 2022
@snewcomer snewcomer marked this pull request as ready for review April 30, 2022 12:25
@snewcomer snewcomer merged commit 8cfb269 into master Apr 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the sn/fix-isempty branch April 30, 2022 12:54
@runspired runspired removed the Bug label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ember-data/record-data RecordData.isEmpty implementation should consider isNew in calculation
2 participants