-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port more types work over from #7585 #7954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
PR is targeting canary (default)
🏷️ chore
This PR primarily refactors code or updates dependencies
typescript
For issues and PRs relating to typescript convertion
labels
Apr 15, 2022
Asset Size Report for a59fee7 Modern Builds ✅ EmberData shrank by -184.84 KB (-39.11 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) ✅ EmberData shrank by -223.33 KB (-42.14 KB compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🎯 canary
PR is targeting canary (default)
🏷️ chore
This PR primarily refactors code or updates dependencies
typescript
For issues and PRs relating to typescript convertion
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chopping as much as I can off that PR to get us to a decent starting point from which to add registries and generics. Since that's a relatively big lift, as much other typing as we can get in place first will help, even if the types are somewhat off today (for instance casting to RecordInstance or DSModel or DSModelSchema)