fix test runs, update lts support tests #8027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
|
Asset Size Report for b43d5d0 Modern Builds ☑️ EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis (Modern)Modern Builds (No Rollup) ☑️ EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis (Modern) |
Turbo87
reviewed
Jul 28, 2022
| }, | ||
| "engines": { | ||
| "node": "12.* || >= 14.*" | ||
| "node": "12.* || >= 14.*", | ||
| "yarn": "1.22.19" |
There was a problem hiding this comment.
this change is causing issues for people installing ember-data with older yarn versions:
ember-data@4.6.0: The engine "yarn" is incompatible with this module. Expected version "1.22.19". Got "1.22.18"
There was a problem hiding this comment.
Ah. I forgot that is going to get applied externally. We should remove it then. Annoying cause it's nice for folks that don't use Volta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.