[BUGFIX] Serialize null array items as empty strings #8083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
ajkovar
added a commit
to ajkovar/data
that referenced
this pull request
Aug 19, 2022
|
@camerondubas backport to 3.28 in progress |
runspired
pushed a commit
that referenced
this pull request
Sep 12, 2022
runspired
added a commit
that referenced
this pull request
Sep 12, 2022
* backport fix for #7786 from #7882 * schedule watchTypeIfUnseen to prevent loop (#8008) * schedule watchTypeIfUnseen to prevent loop fixes #8006 * Update debug-adapter-test.js * Update index.js * Update index.js * fix test * Update debug-adapter-test.js * keep Watching Model Types with store.push * add comment * fix test * [BUGFIX] serialize null array items to string (#8083) * port fix from #7834 for #7824 Co-authored-by: patricklx <patricklx@users.noreply.github.com> Co-authored-by: Cameron Dubas <camerondubas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While moving off jquery, I noticed a difference in how the ember-data serializes
nullin arrays in query params.jQuery's buildParams (link) checks for
nullin an array and sets it to an empty stringember-data doesn't have the explicit
nullcheck (link), sonullvalues in arrays get treated like objects.This results in urls that decode to:
rather than the expected
This PR fixes this by adding an explicit null check.
Would like to see this fix back-ported to 3.28 as that's where I am experiencing it.
Type of PR
What kind of change is this?