-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Upgrades #8121
Documentation Upgrades #8121
Conversation
Asset Size Report for 1ea2607 Modern Builds ☑️ EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) ☑️ EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
|
Performance Report for 1ea2607 Scenario - basic-record-materialization:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the package breakdown is a huge benefit! For the intro sections, I think it would benefit from a catchy hook, if you have one. “What makes this special?” is the question to try and answer. Also, as it is currently, it requires a lot of implicit knowledge to understand what the library does for you. What do you think about saying some of it in plainer terms? I can help draft some possible changes if you are into the idea. I also think this can be merged as is and provide a lot of valuable info.
Also would you like to standardize around referring to the whole thing as EmberData? We can update that in lots of other places if you want.
Co-authored-by: Jen Weber <j@jenweber.me>
Co-authored-by: Jen Weber <j@jenweber.me>
Notes for the release