fix: deprecated record-array rejectBy use optional value if supplied #8399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an optional value supplied as second arg to `rejectBy` it should be compared to the value retrieved using the `key`.
mrloop
commented
Jan 18, 2023
| @@ -141,6 +141,49 @@ module('unit/record-arrays/record-array - DS.RecordArray', function (hooks) { | |||
| } | |||
| ); | |||
|
|
|||
| deprecatedTest( | |||
| '#rejectBy', | |||
| { id: 'ember-data:deprecate-array-like', until: '5.0', count: 3 }, | |||
There was a problem hiding this comment.
not sure what value count should be.
There was a problem hiding this comment.
count is number of expected times this deprecation will be seen
runspired
added
🏷️ bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an optional value supplied as second arg to
rejectByit should be compared to the value retrieved using thekey.Notes for the release
Fix regression in deprecated
rejectBybehaviour when optional value to test against is used.