Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: fix: eliminate SSR/Test memory leak #8436

Merged
merged 6 commits into from
Feb 27, 2023
Merged

perf: fix: eliminate SSR/Test memory leak #8436

merged 6 commits into from
Feb 27, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Feb 27, 2023 •
edited
Loading

  • Fixes memory leaks where during application teardown the graph would be re-instantiated
  • cleans up some smaller leakage that should only affect Data's own tests.

@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue 🏷️ perf PRs that improve performance in a notable way labels Feb 27, 2023
@runspired runspired mentioned this pull request Feb 27, 2023
Closed
@runspired runspired merged commit 5f0bf64 into master Feb 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-memory-leak branch February 27, 2023 09:46
runspired added a commit that referenced this pull request Feb 27, 2023
@runspired
perf: fix: eliminate SSR/Test memory leak (#8436)
05385f6 
* perf: fix: eliminate SSR/Test memory leak

* more leak catching

* more infra

* fixup all the leaks

* fix lint

* fix tsc
runspired added a commit that referenced this pull request Feb 27, 2023
@runspired
perf: fix: eliminate SSR/Test memory leak (#8436)
d279c7d 
* perf: fix: eliminate SSR/Test memory leak

* more leak catching

* more infra

* fixup all the leaks

* fix lint

* fix tsc
This was referenced Feb 27, 2023
Merged
Merged
runspired added a commit that referenced this pull request Feb 27, 2023
@runspired
Backport EmberConcurrency and Memory Leak Fixes (#8438)
2c0d506 
- perf: fix: eliminate SSR/Test memory leak (#8436)
- fix: de-cycle ember-concurrency access of promise (#8435)
runspired added a commit that referenced this pull request Feb 27, 2023
@runspired
Backport EmberConcurrency and Memory Leak fixes (#8439)
c27839d 
- perf: fix: eliminate SSR/Test memory leak (#8436)
- fix: de-cycle ember-concurrency access of promise (#8435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue 🏷️ perf PRs that improve performance in a notable way
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@runspired