feat: public API to support cache insert/remove operations #8454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves blockers for Implementing
cache.putand the broader Cache V2 Spec.The Cache v2 RFC will need to be updated with this addition.
One thing this surfaced that isn't great is that our cache implementation needs a small bit of knowledge of loading state; however, I suspect this need will vanish once v2 is fully implemented as the cache will have a clearer picture of when a push is an update vs an insert. Today various things mean the
__peeklies to us in our implementation.With this change the importance of cache implementations getting their notifications story correct becomes paramount. We may need to dedupe and buffer notifications in the subscription service to prevent push based reactivity systems from being overly churned.