Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Store.request #8472

Merged
merged 21 commits into from
Mar 17, 2023
Merged

feat: Store.request #8472

merged 21 commits into from
Mar 17, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Mar 15, 2023

Implements Store.request making use of Cache.put and Cache.peekRequest.

This PR:

  • Store.request
  • Store.lifetimes support
  • Store.requestManager docs/types
  • ember-data auto-configures RequestManager
  • findAll as request op
  • query as request op
  • queryRecord as request op

ToGo:

  • findRecord as request op
  • saveRecord as request op
  • findBelongsTo as request op
  • findHasMany as request op
  • enforce immutability in dev
  • handle error documents in cache
  • handle meta documents in cache
  • lots of tests
  • no seriously, lots of tests
  • update docs for RequestManager.useCache
  • implement new Collection mode to properly reflect ResourceDocument
  • ensure single-resource-document requests are notified when data changes
  • determine Cache "mutability" of CollectionResourceDocument
  • add tests for enhancing context.request in RequestManager before calling next

Other Notes:

  • clarify intended Error handling mechanisms/propagation
  • update RFC for RequestManager.useCache
  • update RFC for lifetimes.isSoftExpired/isHardExpired
  • update RFC for rename data => content

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Mar 15, 2023
@runspired runspired added 5.0 Roadmap 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 labels Mar 16, 2023
@runspired runspired merged commit 24eb0e9 into main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 Roadmap 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant