feat: stable document identity #8531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added
🎯 canary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8530
Originally for the RFC we'd intended for the lifetimes service to take a stable identifier, as the implementation was built it felt like maybe we didn't actually need this concept, but now that we're deeper in we find our initial design was correct.
This makes use of the existing
IdentifiersCachewhich serves as a configurable way to determine stable identity from any opaque data (in this case, theRequest). We provide default generation of identity (cacheOptions.keyfalling back tourlonly whenmethodis absent orGET), but users may configure this themselves.