Fix: don't clear RecordArray if remaining record does not match the removed record #8570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
changed the title
esbanarango
added a commit
to esbanarango/data
that referenced
this pull request
Apr 16, 2023
…emoved record (emberjs#8570) * Update record-array-test.js * add fix --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
esbanarango
added a commit
to esbanarango/data
that referenced
this pull request
Apr 16, 2023
…emoved record (emberjs#8570) * Update record-array-test.js * add fix --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
esbanarango
added a commit
to esbanarango/data
that referenced
this pull request
Apr 16, 2023
…emoved record (emberjs#8570) * Update record-array-test.js * add fix --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
runspired
added a commit
that referenced
this pull request
Apr 16, 2023
…es not match the removed record (#8572) * Fix: don't clear RecordArray if remaining record does not match the removed record (#8570) * Update record-array-test.js * add fix --------- Co-authored-by: Chris Thoburn <runspired@gmail.com> * minor docs fix to trigger build --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
3 tasks
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8569
Previously, removing a record only checked that the record was still a member of the array if
removes.length !== state.length, this missed the case where when exactly two records exist and one is removed and the removal is double-notified the record to remove may not be the record in the array.The double-notification is something we should also investigate, it's likely that we should not notify the state change for
isDeleted, only for when the deletion is persisted. We also likely should not notify when unloadRecord is called on something whose deletion has been persisted. Both of these cases are leading the over-notification, the first for an extra add, the second for an extra remove.