Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @ember-data/debug should declare its peer-dependency on @ember-data/store #8703

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

runspired
Copy link
Contributor

This fix will need to be brought forward for newer releases as well.

resolves #8701

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue backport-lts PR targets the current lts branch lts-4-12 Long Term LTS Maintenance labels Jul 12, 2023
@runspired runspired linked an issue Jul 12, 2023 that may be closed by this pull request
@runspired runspired linked an issue Jul 12, 2023 that may be closed by this pull request
@runspired runspired merged commit a702115 into lts-4-12 Jul 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-peer-dep branch July 12, 2023 21:35
jrjohnson pushed a commit to jrjohnson/ember-data that referenced this pull request Jul 28, 2023
@jrjohnson jrjohnson mentioned this pull request Jul 28, 2023
runspired added a commit that referenced this pull request Jul 28, 2023
* fix: @ember-data/debug should declare its peer-dependency on @ember-data/store (#8703)

* fix: de-dupe coalescing when includes or adapterOptions is present but still use findRecord (#8704)

* fix: make implicit relationship teardown following delete of related record safe (#8705)

* fix: catch errors during didCommit in DEBUG (#8708)

---------

Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com>
jrjohnson pushed a commit to jrjohnson/ember-data that referenced this pull request Jul 28, 2023
runspired added a commit that referenced this pull request Jul 28, 2023
* fix: @ember-data/debug should declare its peer-dependency on @ember-data/store (#8703)

* fix: de-dupe coalescing when includes or adapterOptions is present but still use findRecord (#8704)

* fix: make implicit relationship teardown following delete of related record safe (#8705)

* fix: catch errors during didCommit in DEBUG (#8708)

---------

Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-lts PR targets the current lts branch 🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.12+ @ember-data/debug has undeclared peer-dep on @ember-data/store
1 participant