Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix paths in transform deprecations #8892

Merged
merged 1 commit into from
Sep 20, 2023
Merged

doc: Fix paths in transform deprecations #8892

merged 1 commit into from
Sep 20, 2023

Conversation

HeroicEric
Copy link
Member

@HeroicEric HeroicEric commented Sep 19, 2023 •
edited
Loading

This fixes the paths in the deprecation messages about "auto-magically installing" transforms.

Example error when using the current paths:

Uncaught Error: Could not find module `ember-data/serializer/transform` imported from `<MY_APP>/transforms/date`
    at missingModule (loader.js:247:1)
    at findModule (loader.js:258:1)
    at Module.findDeps (loader.js:168:1)
    at findModule (loader.js:262:1)
    at requireModule (loader.js:24:1)
    at ModuleRegistry.get (index.js:25:1)
    at Resolver._extractDefaultExport (index.js:377:1)
    at Resolver.resolveOther (index.js:139:1)
    at Resolver.resolve (index.js:160:1)
    at resolve (index.js:743:1)

@HeroicEric
doc: Fix paths in transform deprecations
3e1f033 
This fixes the paths in the deprecation messages about "auto-magically
installing" transforms.
@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Sep 20, 2023
@runspired runspired merged commit c5f7179 into emberjs:main Sep 20, 2023
25 of 27 checks passed
@HeroicEric HeroicEric deleted the fix-transform-deprecation-import-paths branch September 20, 2023 17:01
BoussonKarel pushed a commit to BoussonKarel/data that referenced this pull request Oct 6, 2023
@HeroicEric @BoussonKarel
doc: Fix paths in transform deprecations (emberjs#8892)
538c8d6 
This fixes the paths in the deprecation messages about "auto-magically
installing" transforms.
runspired pushed a commit that referenced this pull request Feb 13, 2024
@HeroicEric @runspired
doc: Fix paths in transform deprecations (#8892)
f612e87 
This fixes the paths in the deprecation messages about "auto-magically
installing" transforms.
@runspired runspired mentioned this pull request Feb 13, 2024
Merged
runspired added a commit that referenced this pull request Feb 13, 2024
@runspired @HeroicEric
feat: improved lifetimes-service capabilities (#9224)
f3d2b74 
* feat: improved lifetimes-service capabilities (#9163)

* feat: improved lifetimes-service capabilities

* fix lint

* fix lint

* doc: Fix paths in transform deprecations (#8892)

This fixes the paths in the deprecation messages about "auto-magically
installing" transforms.

---------

Co-authored-by: Eric Kelly <602204+HeroicEric@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeroicEric @runspired