Fix ESLint for VSCode #9055
Merged
Fix ESLint for VSCode #9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitKrystan
changed the title
gitKrystan
force-pushed
the
cherry-c811696167415a55b0c1a424c0ebf4585310733d
branch
from
c811696 to
ef7a2f4
Compare
gitKrystan
commented
Oct 25, 2023
| @@ -20,13 +32,13 @@ function rules() { | |||
| 'prefer-rest-params': 'off', | |||
| 'prefer-const': 'error', | |||
|
|
|||
| "prettier/prettier": [ | |||
| "error", | |||
| 'prettier/prettier': [ | |||
There was a problem hiding this comment.
NOTE: We currently don't lint for prettier (or anything AFAICT) in this part of the project. Should we?
There was a problem hiding this comment.
probably. I want to separate prettier out like we did in AB frontend, but haven't had a chance to. Would handle this.
Co-authored-by: Chris Thoburn <runspired@gmail.com>
gitKrystan
force-pushed
the
cherry-c811696167415a55b0c1a424c0ebf4585310733d
branch
from
ef7a2f4 to
9993179
Compare
runspired
approved these changes
Oct 25, 2023
runspired
added
🎯 canary
gitKrystan
deleted the
cherry-c811696167415a55b0c1a424c0ebf4585310733d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix ESLint for VSCode
Notes for the release