Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract qunit ESLint config #9062

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Extract qunit ESLint config #9062

merged 1 commit into from
Oct 26, 2023

Conversation

gitKrystan
Copy link
Contributor

@gitKrystan gitKrystan commented Oct 26, 2023 •
edited
Loading

Description

  • Extracts reusable ESLint config for QUnit files
  • Uses that config in the one place we currently have QUnit stuff that is linted
  • Adds eslint-plugin-qunit

Will probably ignore some of the eslint-plugin-qunit rules as I use this config on more projects in the monorepo.

Notes for the release

@gitKrystan gitKrystan added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies labels Oct 26, 2023
@gitKrystan gitKrystan enabled auto-merge October 26, 2023 20:32
@gitKrystan gitKrystan merged commit bccaa12 into main Oct 26, 2023
22 of 24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the qunit-eslint-config branch October 26, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitKrystan @runspired