Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @ember-data/legacy-compat/builders #9319

Merged
merged 18 commits into from
Apr 9, 2024
Merged

Add @ember-data/legacy-compat/builders #9319

merged 18 commits into from
Apr 9, 2024

Conversation

gitKrystan
Copy link
Contributor

@gitKrystan gitKrystan commented Apr 4, 2024 •
edited
Loading

Description

Adds @ember-data/legacy-compat/builders module with builders for migrating from store methods to store.request.

These builders enable you to migrate your codebase to using the correct syntax for store.request while temporarily preserving legacy behaviors. This is useful for quickly upgrading an entire app to a unified syntax while a longer incremental migration is made to shift off of adapters and serializers.

  • findRecord
  • query
  • queryRecord
  • findAll
  • saveRecord

Notes for the release

@gitKrystan gitKrystan added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Apr 4, 2024
@gitKrystan gitKrystan force-pushed the legacy-compat-builders branch from 5c63e62 to 4c78037 Compare April 5, 2024 18:10
@gitKrystan gitKrystan changed the title legacy compat builders Add @ember-data/legacy-compat/builders Apr 5, 2024
@gitKrystan gitKrystan force-pushed the legacy-compat-builders branch 2 times, most recently from a3b8892 to 73fdf43 Compare April 8, 2024 18:04
@gitKrystan gitKrystan force-pushed the legacy-compat-builders branch from 73fdf43 to e277367 Compare April 8, 2024 18:10
runspired
runspired approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, cleanup on doc tag ordering and pass through of generics would be good though

@runspired runspired merged commit 286f5bc into main Apr 9, 2024
19 checks passed
@runspired runspired deleted the legacy-compat-builders branch April 9, 2024 08:25
Baltazore
Baltazore reviewed Apr 13, 2024
View reviewed changes
tests/main/tests/integration/legacy-compat/save-record-test.ts
@@ -222,8 +222,8 @@ module('Integration - legacy-compat/builders/saveRecord', function (hooks) {
const { content: savedPost } = await store.request<Post>(saveRecord(existingPost));

assert.strictEqual(savedPost.id, '1', 'post has correct id');
assert.strictEqual(savedPost.name, 'Krystan rules, you drool', 'post has correct name');
assert.true(savedPost.isDeleted, 'post isDeleted');
assert.strictEqual(savedPost.name, 'Chris drools, Krystan rules', 'post has correct name');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

gitKrystan added a commit that referenced this pull request Apr 29, 2024
@gitKrystan
Copy-pasta from #9319
3094041
@gitKrystan gitKrystan mentioned this pull request Apr 29, 2024
Merged
runspired pushed a commit that referenced this pull request Apr 29, 2024
@gitKrystan
Backport #9319 to lts-4-12: Add @ember-data/legacy-compat/builders (#…
9779c67 
…9386)

* Copy-pasta from #9319

* Make it work
@gitKrystan gitKrystan mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baltazore Baltazore Baltazore left review comments

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
EmberData
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitKrystan @runspired @Baltazore