fix: Make IS_MAYBE_MIRAGE simplified #9385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
approved these changes
May 3, 2024
runspired
added
🎯 canary
runspired
reviewed
May 3, 2024
MichalBryxi
force-pushed
the
mb/is-maybe-mirage-v2
branch
from
aa8f128 to
9fdde1b
Compare
|
Sigh me :) Maybe would help if I would not just ignore the hooks setup and figure out what is this error about: git commit --amend
.git/hooks/pre-commit: line 2: ./node_modules/pre-commit/hook: No such file or directoryOk, let's try one more time. |
MichalBryxi
force-pushed
the
mb/is-maybe-mirage-v2
branch
from
9fdde1b to
7e921c6
Compare
- In previous version we fixed the code for FireFox that can now work in FireFox which has different `.toString()` implementation - This change should make it more error prone as it completely removes whitespace from the strings and then compares them
MichalBryxi
force-pushed
the
mb/is-maybe-mirage-v2
branch
from
7e921c6 to
81fcc8d
Compare
|
@MichalBryxi we have no hooks! that means you cloned us at a point long ago when we did. You can safely remove that hook file/directory. |
runspired
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.toString()implementationNotes for the release