Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v2 addons #9407

Merged
merged 1 commit into from
May 28, 2024
Merged

feat: v2 addons #9407

merged 1 commit into from
May 28, 2024

Conversation

runspired
Copy link
Contributor

@runspired runspired commented May 13, 2024

monitoring to see if v2 addons are feasible yet

In our work in #9292 we discovered that

  • rolling up types(.d.ts) is not yet feasible, though dts-buddy approach was not yet explored (vite, rollup, tsc, and api-extractor approaches were)
  • EmberData can't ship v2 addons (yet) due to webpack bugs in production builds improperly dropping various exports. This may (or may not) be related the auto-import layering issue, though is likely distinct.

We merged the big PR with all the work but turned off type rollup and configured most of the packages to continue to ship as v1 addons with a simple switch to upgrade them to v2 if possible. This PR triggered that switch so that we can debug these issues.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels May 13, 2024
@runspired runspired merged commit 1f965a9 into main May 28, 2024
17 of 18 checks passed
@runspired runspired deleted the v2-addon-bump branch May 28, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant