Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RequestState.abort to be used with on modifier #9454

Merged
merged 1 commit into from
May 23, 2024

Conversation

gitKrystan
Copy link
Contributor

@gitKrystan gitKrystan commented May 22, 2024

Description

Fixes the following error encountered when using state.abort (yielded by the Request component) with the on modifier:

util.js:579 Uncaught Error: You accessed `this._future` from a function passed to the `on` modifier, but the function itself was not bound to a valid `this` context. Consider updating to use a bound function (for instance, use an arrow function, `() => {}`).
    at assertOnProperty (util.js:579:1)
    at Object.get (util.js:583:1)
    at Proxy.abort (index.js:30:1364)

Notes for the release

@gitKrystan gitKrystan added 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels May 22, 2024
@gitKrystan gitKrystan force-pushed the reactive-state-fixes branch 2 times, most recently from d23d7d8 to 91b4053 Compare May 22, 2024 23:52
@gitKrystan gitKrystan force-pushed the reactive-state-fixes branch from 91b4053 to 15db0d6 Compare May 23, 2024 00:04
@runspired runspired merged commit af7ede3 into main May 23, 2024
17 of 18 checks passed
@runspired runspired deleted the reactive-state-fixes branch May 23, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants