Skip to content

Commit

Permalink
Update Ember CLI to v3.5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
bertdeblock committed Oct 1, 2022
1 parent 0d55399 commit 84c6081
Show file tree
Hide file tree
Showing 3 changed files with 572 additions and 169 deletions.
24 changes: 0 additions & 24 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,6 @@ jobs:
matrix:
os: ['ubuntu', 'windows', 'macOS']
node: ['14', '16', '18']
exclude:
# excludes node 14 on macOS, this is because
# ember-cli (until ~ 3.12) calls
# `fs.writeFileSync('./tmp/.metadata_never_index)` on macOS platforms
# to instruct spotlight to avoid indexing the local tmp folder
# unfortunately, ember-cli does not pass a value for second arg (the
# content to write) and Node 14 added an assertion
#
# TODO: delete this when we have dropped Node 6 and can update
# ember-cli to a version that doesn't do this
- os: 'macOS'
node: '14'

steps:
- uses: actions/checkout@v1
Expand All @@ -66,18 +54,6 @@ jobs:
matrix:
os: ['ubuntu', 'windows']
node: ['14', '16', '18']
exclude:
# excludes node 14 on macOS, this is because
# ember-cli (until ~ 3.12) calls
# `fs.writeFileSync('./tmp/.metadata_never_index)` on macOS platforms
# to instruct spotlight to avoid indexing the local tmp folder
# unfortunately, ember-cli does not pass a value for second arg (the
# content to write) and Node 14 added an assertion
#
# TODO: delete this when we have dropped Node 6 and can update
# ember-cli to a version that doesn't do this
- os: 'macOS'
node: '14'

steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"common-tags": "^1.8.0",
"console-ui": "^2.2.2",
"core-object": "^3.1.5",
"ember-cli": "~3.3.0",
"ember-cli": "~3.5.0",
"ember-cli-dependency-checker": "^3.0.0",
"eslint": "^4.0.0",
"ember-cli-htmlbars": "^3.0.0",
Expand Down
Loading

0 comments on commit 84c6081

Please sign in to comment.