Fixed regex that resulted in an invalid range in older browsers #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex [_/-\s] is invalid as it creates a range between the / and the \s characters. The hyphen needs to be escaped or at the end.
olivia
added a commit
that referenced
this pull request
Sep 4, 2015
Fixed regex that resulted in an invalid range in older browsers
|
Thanks Jerel! Merged into master. |
|
@OFbriggs can you cut a new release so we can pull this into Ember Data 1.13? |
|
Released with v1.9.2 @fivetanley |
jerel
added a commit
to jerel/ember-cli-mirage
that referenced
this pull request
Sep 4, 2015
This was referenced Sep 10, 2015
bmac
pushed a commit
to emberjs/data
that referenced
this pull request
Sep 10, 2015
…ded fix for older browsers (see: emberjs/ember-inflector#89 ). (cherry picked from commit 9632531) Conflicts: package.json (cherry picked from commit dfd05f3)
bmac
pushed a commit
to emberjs/data
that referenced
this pull request
Sep 10, 2015
…ded fix for older browsers (see: emberjs/ember-inflector#89 ). (cherry picked from commit 9632531) Conflicts: package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex
[_/-\s]will cause error "Invalid range in character set" because it creates a range between the/and the\scharacters. The hyphen needs to be escaped or moved to the end. Problem was observed in IE8, Firefox 14, and 24.Related: http://stackoverflow.com/questions/23496973/invalid-range-in-character-class-regex-firefox