correctly load scripts in chrome & firefox #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
changed the title
patricklx
changed the title
| @@ -3,6 +3,7 @@ | |||
| // TODO: make this conditional, only do it when requested. | |||
| // only inject boot script when on an HTML page | |||
| if (document.contentType === 'text/html') { | |||
| window.EmberENV = { _DEBUG_RENDER_TREE: true }; | |||
There was a problem hiding this comment.
Wouldn't we want to check for existence of window.EmberENV here too instead of setting it to our own object?
There was a problem hiding this comment.
Not needed here. This really absolutely runs before anything else
| @@ -273,19 +273,31 @@ module.exports = function (defaults) { | |||
|
|
|||
| replacementPattern = replacementPattern.concat(emberInspectorVersionPattern); | |||
|
|
|||
| const firefoxBackgroundServiceReplacement = [ | |||
There was a problem hiding this comment.
What is this for? Firefox should support manifest v3, right?
There was a problem hiding this comment.
It doesn't... Not all of it
There was a problem hiding this comment.
There was a problem hiding this comment.
this is available since manifest v3, but ignored in firefox, use wrappedJSObject for firefox https://developer.chrome.com/docs/extensions/reference/scripting/#type-ExecutionWorld
|
@RobbieTheWagner i found a better way for firefox |
RobbieTheWagner
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does not work for firefox
Also has warnings about permissions
but firefox keeps the order right for script loading
it needs to run before everything else so that ember gets the debug config. If the property is set later, component tree will not work.
this issue only happens on page refresh, then browser uses cached data and immediately runs the scripts, without waiting for the new script that have been added by extensions. this does not happen in firefox, only chrome.
https://bugs.chromium.org/p/chromium/issues/detail?id=634381
fixes #2500