filter out null/undefined nodes #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing due to emberjs/ember.js#12793 |
|
I don't want to sound rude, but can you pls fix this PR? |
|
@IgorKvasn I think the pr is not responsible for the broken build, but I don't know what should be done for it to pass. |
|
I think #512 should fix the build. |
|
I restarted the build now that #512 is merged. |
|
Thanks, I just tried to force-push, but without change it does not work |
|
Looks like build passed. |
rwjblue
added a commit
that referenced
this pull request
Feb 1, 2016
filter out null/undefined nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #506
closes #504