Skip to content
This repository has been archived by the owner on Sep 21, 2020. It is now read-only.

Fix generated controllers to use proxying controllers #14

Merged
merged 1 commit into from
May 29, 2020

Conversation

mmun
Copy link
Member

@mmun mmun commented May 29, 2020

Fixes #13.

@rwjblue
Copy link
Member

rwjblue commented May 29, 2020

@mmun - Test failures are without legacy views:

not ok 1 Chrome 62.0 - [216 ms] - Generated controllers: object controllers are generated correctly
    ---
        actual: >
            
        expected: >
            Alice
        stack: >
                at DOMAssertions.hasText (http://localhost:7357/assets/test-support.js:9508:20)
                at _callee$ (http://localhost:7357/assets/tests.js:22:50)
                at tryCatch (http://localhost:7357/assets/vendor.js:411:40)
                at Generator.invoke [as _invoke] (http://localhost:7357/assets/vendor.js:685:22)
                at Generator.prototype.(anonymous function) [as next] (http://localhost:7357/assets/vendor.js:444:21)
                at asyncGeneratorStep (http://localhost:7357/assets/tests.js:6:105)
        message: >
            Element [data-test-target] has text "Alice"
   

@mmun
Copy link
Member Author

mmun commented May 29, 2020

Yeah, the included logic is wrong. I'll fix that.

@mmun mmun force-pushed the generated-controllers branch 5 times, most recently from cb05e0c to d863543 Compare May 29, 2020 18:01
@mmun mmun force-pushed the generated-controllers branch from d863543 to 4205a03 Compare May 29, 2020 18:12
@mmun mmun merged commit 13a040d into master May 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the generated-controllers branch May 29, 2020 18:29
@mmun mmun added the bug label May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated controllers should be object/array controllers
3 participants