-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asserting error thrown no longer works as of 2.11.3 #141
Comments
okay, so I got several opinions on this:
|
4 tasks
3 tasks
Robdel12
added a commit
to adopted-ember-addons/emberx-select
that referenced
this issue
Mar 24, 2017
According to this ticket (emberjs/ember.js#15013) and this ticket (emberjs/ember-mocha#141) ember 2.11 broke testing exceptions.
Robdel12
added a commit
to adopted-ember-addons/emberx-select
that referenced
this issue
Mar 24, 2017
* Upgrade ember-cli 2.11.0 * Upgrade to ember-cli 2.12.1 * Update mocha tests * ember#release seems to be borked. * Skip test related to testing thrown errors According to this ticket (emberjs/ember.js#15013) and this ticket (emberjs/ember-mocha#141) ember 2.11 broke testing exceptions.
bmeurant
pushed a commit
to bmeurant/ember-array-contains-helper
that referenced
this issue
Apr 9, 2017
Asserting error thrown no longer works as of ember 2.11 see [emberjs/ember.js#15013](emberjs/ember.js#15013) and [emberjs/ember-mocha#141](emberjs/ember-mocha#141)
bmeurant
pushed a commit
to bmeurant/ember-array-contains-helper
that referenced
this issue
Apr 9, 2017
Asserting error thrown no longer works as of ember 2.11 see [emberjs/ember.js#15013](emberjs/ember.js#15013) and [emberjs/ember-mocha#141](emberjs/ember-mocha#141)
bmeurant
pushed a commit
to bmeurant/ember-array-contains-helper
that referenced
this issue
Apr 9, 2017
Asserting error thrown no longer works as of ember 2.11 see (emberjs/ember.js#15013) and (emberjs/ember-mocha#141)
bmeurant
pushed a commit
to bmeurant/ember-array-contains-helper
that referenced
this issue
Apr 9, 2017
Asserting error thrown no longer works as of ember 2.11 see (emberjs/ember.js#15013) and (emberjs/ember-mocha#141)
this seems to be an issue in Ember itself, so I'll close the issue here for now in favor of emberjs/ember.js#15013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unsure where the proper fix belongs, but I believe it surfaced as part of:
emberjs/ember.js#14898
Example of test that now fails since the assertion is not handled by mocha/chai before the error is thrown:
The text was updated successfully, but these errors were encountered: