Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ember-test-helpers ^0.6.0 #128

Merged
merged 1 commit into from
Jan 24, 2017
Merged

Ensure ember-test-helpers ^0.6.0 #128

merged 1 commit into from
Jan 24, 2017

Conversation

blimmer
Copy link

@blimmer blimmer commented Jan 23, 2017

I was experiencing some weird problems and noticed that I was resolving to 0.6.0-beta.1 instead of 0.6.0. I think bumping this resolution to ^0.6.0 or better is appropriate so some don't accidentally resolve to the beta.

I was experiencing some weird problems and noticed that I was resolving to 0.6.0-beta.1 instead of 0.6.0. I think bumping this resolution to ^0.6.0 or better is appropriate so some don't accidentally resolve to the beta.
@Turbo87
Copy link
Member

Turbo87 commented Jan 24, 2017

according to http://jubianchi.github.io/semver-check/ the ^0.6.0-beta.1 constraint should be compatible with 0.6.0, but I agree that we shouldn't use beta versions if the proper version exists already. thanks for the PR!

@Turbo87 Turbo87 merged commit f575810 into emberjs:master Jan 24, 2017
@blimmer blimmer deleted the patch-1 branch January 24, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants