Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin "ember-test-helpers" to v0.6.2 #145

Closed
wants to merge 1 commit into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 17, 2017

the v0.11.x branch and master are currently failing:

not ok 1 PhantomJS 2.1 - Global error: Error: Could not find module require at http://localhost:7357/assets/loader.js, line 58

see emberjs/ember-test-helpers#203

@rwjblue
Copy link
Member

rwjblue commented Apr 17, 2017

Hmm, looks like the loader being used here is quite outdated (1.0.1 of a custom fork?). The loader has provided the 'require' module for quite a while.

@Turbo87
Copy link
Member Author

Turbo87 commented Apr 17, 2017

https://github.com/emberjs/ember-mocha/blob/master/tests/test-support/test-loader.js

no idea where exactly that file is coming from...

EDIT: nevermind, that file seems unrelated...

@rwjblue
Copy link
Member

rwjblue commented Apr 17, 2017

Fixed by #146

@rwjblue rwjblue closed this Apr 17, 2017
@Turbo87 Turbo87 deleted the pin-test-helpers branch April 18, 2017 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants