Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Ember CLI addon #173

Merged
merged 5 commits into from
Dec 6, 2017
Merged

Convert to Ember CLI addon #173

merged 5 commits into from
Dec 6, 2017

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 5, 2017 •
edited
Loading

roughly similar to emberjs/ember-qunit#282

@Turbo87 Turbo87 requested a review from rwjblue December 5, 2017 21:21
@Turbo87 Turbo87 changed the title [WIP] Convert to Ember CLI addon Convert to Ember CLI addon Dec 6, 2017
@Turbo87
Copy link
Member Author

Turbo87 commented Dec 6, 2017

@rwjblue: did a quick skim, generally looks good to me

@Turbo87 Turbo87 merged commit 7a47cc8 into emberjs:master Dec 6, 2017
@Turbo87 Turbo87 deleted the make-addon branch December 6, 2017 08:21
This was referenced Dec 6, 2017
Merged
Merged
@rwjblue
Copy link
Member

rwjblue commented Dec 6, 2017

Ya, LGTM

This was referenced Dec 6, 2017
Merged
Merged
Merged
Open
@Turbo87 Turbo87 added breaking and removed internal labels Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @rwjblue