Update to Ember 3.21 #28
Conversation
|
My idea was - this could go in as patch release. I can create a follow up PR which would upgrade to all the latest and greatest and drop Node.js 6 support but that would require major version bump. |
package.json
Outdated
| "lerna-changelog": "^0.8.0", | ||
| "loader.js": "^4.7.0" | ||
| }, | ||
| "resolutions": { | ||
| "*/sort-package-json": "1.23.0", | ||
| "**/socket.io": "2.1.1" |
There was a problem hiding this comment.
Upstream issue socketio/engine.io#589
package.json
Outdated
| @@ -29,31 +29,36 @@ | |||
| "test:all": "ember try:each" | |||
| }, | |||
| "dependencies": { | |||
| "ember-cli-babel": "^6.16.0", | |||
| "ember-cli-babel": "^7.11.1", | |||
There was a problem hiding this comment.
This is a breaking change anyways, so we might as well drop Node 6 support
package.json
Outdated
| "lerna-changelog": "^0.8.0", | ||
| "loader.js": "^4.7.0" | ||
| }, | ||
| "resolutions": { |
There was a problem hiding this comment.
Let's remove these, the ember-cli-babel bump is a breaking change so we can drop Node 6
package.json
Outdated
| "resolutions": { | ||
| "*/sort-package-json": "1.23.0", | ||
| "**/socket.io": "2.1.1" | ||
| }, | ||
| "engines": { | ||
| "node": "6.* || 8.* || >= 10.*" |
There was a problem hiding this comment.
Will need to update to 8.* || 10.* || >= 12
The issue here is that ember-cli-babel@6 -> ember-cli-babel@7 itself is a major bump (drops support for older ember-cli versions). |
I missed that point. I'll update it then to remove Node.js 6 compatibility and this could be a major version bump. |
SergeAstapov
force-pushed
the
upgrade-ember
branch
from
14effc6 to
5207892
Compare
|
@rwjblue sorry for the delay here. Updated PR with Ember CLI 3.21 and dropped Node,js 8 support as well. |
|
Thank you! |
|
@rwjblue Changelog says this drops support for ember < 3.16. Does that mean it is just not tested against older version or is there a known issue? |
Updating this addon to Ember 3.12, leveraging ember-cli-update.
Upgrades ember-cli-babel to use Babel@7
Had to pin some dependencies to make CI happy and use Node.js 6.x compatible versions.