Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to @ember/ordered-set #5

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Rename to @ember/ordered-set #5

merged 1 commit into from
Nov 6, 2017

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 6, 2017

as discussed in #3 (comment)

@Turbo87 Turbo87 requested review from rwjblue and locks November 6, 2017 15:11
@@ -1,4 +1,4 @@
# ember-ordered-set
# @ember/ordered-set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we maybe want to leave this one matching with the repo name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way, but ember init will always change it back to @ember/ordered-set 🤷‍♂️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Turbo87 Turbo87 merged commit ed242db into emberjs:master Nov 6, 2017
@Turbo87 Turbo87 deleted the rename branch November 6, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants