Merge pull request #89 from workmanw/isolated-container-normalize-needs

`isolated-container` should call `resolver.normalize(fullName)` when resolving needs values.
emberjs · Sep 23, 2014 · f3f8527 · f3f8527
2 parents a773872 + 42c5986
commit f3f8527
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 7 deletions.
diff --git a/dist/amd/isolated-container.js b/dist/amd/isolated-container.js
@@ -15,7 +15,8 @@ define(
       container.register('component-lookup:main', Ember.ComponentLookup);
       for (var i = fullNames.length; i > 0; i--) {
         var fullName = fullNames[i - 1];
-        container.register(fullName, resolver.resolve(fullName));
+        var normalizedFullName = resolver.normalize(fullName);
+        container.register(fullName, resolver.resolve(normalizedFullName));
       }
       return container;
     }

diff --git a/dist/cjs/isolated-container.js b/dist/cjs/isolated-container.js
@@ -12,7 +12,8 @@ exports["default"] = function isolatedContainer(fullNames) {
   container.register('component-lookup:main', Ember.ComponentLookup);
   for (var i = fullNames.length; i > 0; i--) {
     var fullName = fullNames[i - 1];
-    container.register(fullName, resolver.resolve(fullName));
+    var normalizedFullName = resolver.normalize(fullName);
+    container.register(fullName, resolver.resolve(normalizedFullName));
   }
   return container;
 }
diff --git a/dist/globals/main.js b/dist/globals/main.js
@@ -13,7 +13,8 @@ exports["default"] = function isolatedContainer(fullNames) {
   container.register('component-lookup:main', Ember.ComponentLookup);
   for (var i = fullNames.length; i > 0; i--) {
     var fullName = fullNames[i - 1];
-    container.register(fullName, resolver.resolve(fullName));
+    var normalizedFullName = resolver.normalize(fullName);
+    container.register(fullName, resolver.resolve(normalizedFullName));
   }
   return container;
 }

diff --git a/dist/named-amd/main.js b/dist/named-amd/main.js
@@ -15,7 +15,8 @@ define("ember-qunit/isolated-container",
       container.register('component-lookup:main', Ember.ComponentLookup);
       for (var i = fullNames.length; i > 0; i--) {
         var fullName = fullNames[i - 1];
-        container.register(fullName, resolver.resolve(fullName));
+        var normalizedFullName = resolver.normalize(fullName);
+        container.register(fullName, resolver.resolve(normalizedFullName));
       }
       return container;
     }

diff --git a/lib/isolated-container.js b/lib/isolated-container.js
@@ -11,7 +11,8 @@ export default function isolatedContainer(fullNames) {
   container.register('component-lookup:main', Ember.ComponentLookup);
   for (var i = fullNames.length; i > 0; i--) {
     var fullName = fullNames[i - 1];
-    container.register(fullName, resolver.resolve(fullName));
+    var normalizedFullName = resolver.normalize(fullName);
+    container.register(fullName, resolver.resolve(normalizedFullName));
   }
   return container;
 }
diff --git a/test/main.spec.js b/test/main.spec.js
@@ -35,8 +35,9 @@ var registry = {
   'template:components/pretty-color': 'Pretty Color: <span class="color-name">{{name}}</span>'.compile(),
   'route:foo': Ember.Route.extend(),
   'controller:foos': Ember.ArrayController.extend(),
+  'controller:hello-world': Ember.ObjectController.extend(),
   'controller:bar': Ember.Controller.extend({
-    needs: ['foos']
+    needs: ['foos', 'helloWorld']
   }),
   'model:post': Post,
   'model:comment': Comment,
@@ -48,6 +49,9 @@ var registry = {
 var Resolver = Ember.DefaultResolver.extend({
   resolve: function(fullName) {
     return registry[fullName] || this._super.apply(this, arguments);
+  },
+  normalize: function(fullName) {
+    return Ember.String.dasherize(fullName);
   }
 });
 
@@ -84,27 +88,31 @@ test("root element is auto-added before moduleFor callback", function() {
 //});
 
 moduleFor('controller:bar', 'moduleFor with bar controller', {
-  needs: ['controller:foos']
+  needs: ['controller:foos', 'controller:helloWorld']
 });
 
 test('exists', function() {
   var bar = this.subject();
 
   var foos = bar.get('controllers.foos');
+  var helloWorld = bar.get('controllers.helloWorld');
 
   ok(bar);
   ok(bar instanceof Ember.Controller);
   ok(foos instanceof Ember.ArrayController);
+  ok(helloWorld instanceof Ember.ObjectController);
 });
 
 test('exists again', function() {
   var bar = this.subject();
 
   var foos = bar.get('controllers.foos');
+  var helloWorld = bar.get('controllers.helloWorld');
 
   ok(bar);
   ok(bar instanceof Ember.Controller);
   ok(foos instanceof Ember.ArrayController);
+  ok(helloWorld instanceof Ember.ObjectController);
 });
 
 moduleForModel('whazzit', 'moduleForModel whazzit without adapter');