Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reason without stack but with message will error #227

Closed
stefanpenner opened this issue Jun 2, 2016 · 0 comments
Closed

reason without stack but with message will error #227

stefanpenner opened this issue Jun 2, 2016 · 0 comments

Comments

@stefanpenner
Copy link
Member

stefanpenner commented Jun 2, 2016 •
edited
Loading

https://github.com/rwjblue/ember-qunit/blob/master/lib/ember-qunit/test-wrapper.js#L19 is flawed if an error has no stack, but has a reason.

In chrome this isn't possible, but some other environments new Error('foo') without a throw wont process a stack.
@rwjblue rwjblue closed this as completed in 9bc6d11 Jun 2, 2016
rwjblue added a commit that referenced this issue Jun 2, 2016
@rwjblue
Merge pull request #228 from rwjblue/stefanpenner-patch-1
47d930c 
[FIXES #227]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanpenner