-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing in beforeEach() due to module being undefined #268
Labels
Comments
Turns out this is a bug in QUnit triggered when the first or last test in a module is skipped. I opened a PR with a fix over there. |
Labelling as a bug and leaving this open even though the fix will be upstream. |
Fix has been merged upstream, will be out in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm seeing a bizarre error that appears to be caused by #260. I run my whole suite, and a few modules towards the end of the suite fail because
module
is undefined in beforeEach. I put in some logging, and before is not being called for these module. I can seebeforeEach()
being called for each test (withmodule=undefined
), andafter
being called, butbefore
is not getting called.The tests that are failing are my route and service unit tests -- a couple of route tests pass, then the rest and all the service tests fail, then next is some non-ember-qunit modules that pass.
The text was updated successfully, but these errors were encountered: