-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a skip before test fails when this.subject() is called in beforeEach #269
Comments
This sounds suspicious similar to #268 (comment) which was fixed upstream in qunitjs/qunit#1156... |
@rwjblue wow, incredible timing. I can test my example project with an updated qunit once there's a release. Should we leave this issue open until |
A fresh |
@trentmwillis, @rwjblue: example tests pass with |
I have a reproduction example at amiel/qunit-skip-example (this test shows the specific case).
I'm happy to look in to this further, but wanted to start by reporting the issue.
Does anyone know off-hand what the issue is?
Use Case
We frequently use
this.subject()
inbeforeEach
to set attributes on the subject that all tests share.Normally this hasn't caused any issues, even when using
skip
, but we ran in to an exception whenskip
happened to be the first test.Details
The first exception is:
Which happens in
qunit-module.js
(inbeforeEach
). This is why I reported the bug here, but I'm not sure if it could be a symptom of an issue with qunit.The text was updated successfully, but these errors were encountered: