Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I believe these deps, are incorrect #59

Closed
stefanpenner opened this issue May 30, 2014 · 10 comments
Closed

I believe these deps, are incorrect #59

stefanpenner opened this issue May 30, 2014 · 10 comments

Comments

@stefanpenner
Copy link
Member

https://github.com/rpflorence/ember-qunit/blob/master/dist/named-amd/main.js#L22-L23

./isolated-container is not a sibling of ember-qunit but rather a descendent of it.

@wycats
Copy link
Member

wycats commented May 30, 2014

Much 😢

@stefanpenner
Copy link
Member Author

@rpflorence would love to see a solution to this.

@ryanflorence
Copy link
Contributor

Those files are siblings of the "main" file.

I hate named AMD. I don't foresee myself spending any time on this.

@stefanpenner
Copy link
Member Author

The largest consumer of this library cannot upgrade to a fixed loader because of this.

When you diverged history and took stewardship of this project you accepted that sort of responsibility.

@ryanflorence
Copy link
Contributor

What is the output supposed to look like?

We have the main entry requiring its sibling files with relative paths, what are the paths supposed to be? In normal AMD, this is exactly correct. Its also what the r.js optimizer does.

If we want "ember-amd", then that's fine, just tell me what the output should be and we can add it to broccoli-dist-es6-module

@stefanpenner
Copy link
Member Author

define("ember-qunit",
  ["ember","./isolated-container","./module-for","./module-for-component","./module-for-model","./test","./test-resolver","exports"],

->

define("ember-qunit",
  ["ember","ember-qunit/isolated-container","ember-qunit/module-for","ember-qunit/module-for-component","ember-qunit/module-for-model","ember-qunit/test","ember-qunit/test-resolver","exports"],

@ryanflorence
Copy link
Contributor

This is the output of the es6-transpiler when you use relative paths in your main script.

Not using relative paths in main would then break other module loaders.

I'm not sure what to do.

@stefanpenner
Copy link
Member Author

@abuiles has been working with me to bring leaf's ability to handle arbitrary module inputs (including) anonymous AMD to broccoli in the form of a filter.

This deps are actually incorrect, but once ^^ lands we should phase them out entirely.

for reference @mmun actually wrote his own es6-module-filter that uses squares transpiler for broccoli to handle this naming issue: https://github.com/mmun/broccoli-es6-module-transpiler

@ryanflorence
Copy link
Contributor

\o/

On Tue, Jun 10, 2014 at 4:04 PM, Stefan Penner notifications@github.com
wrote:

@abuiles https://github.com/abuiles has been working with me to bring
leaf https://github.com/stefanpenner/leaf's ability to handle arbitrary
module inputs (including) anonymous AMD to broccoli in the form of a filter.

This deps are actually incorrect, but once ^^ lands we should phase them
out entirely.


Reply to this email directly or view it on GitHub
#59 (comment)
.

@Turbo87
Copy link
Member

Turbo87 commented Oct 14, 2017

this seems no longer relevant, closing due to age

@Turbo87 Turbo87 closed this as completed Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants