-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I believe these deps, are incorrect #59
Comments
Much 😢 |
@rpflorence would love to see a solution to this. |
Those files are siblings of the "main" file. I hate named AMD. I don't foresee myself spending any time on this. |
The largest consumer of this library cannot upgrade to a fixed loader because of this. When you diverged history and took stewardship of this project you accepted that sort of responsibility. |
What is the output supposed to look like? We have the If we want "ember-amd", then that's fine, just tell me what the output should be and we can add it to |
define("ember-qunit",
["ember","./isolated-container","./module-for","./module-for-component","./module-for-model","./test","./test-resolver","exports"], -> define("ember-qunit",
["ember","ember-qunit/isolated-container","ember-qunit/module-for","ember-qunit/module-for-component","ember-qunit/module-for-model","ember-qunit/test","ember-qunit/test-resolver","exports"], |
This is the output of the es6-transpiler when you use relative paths in your main script. Not using relative paths in main would then break other module loaders. I'm not sure what to do. |
@abuiles has been working with me to bring leaf's ability to handle arbitrary module inputs (including) anonymous AMD to broccoli in the form of a filter. This deps are actually incorrect, but once ^^ lands we should phase them out entirely. for reference @mmun actually wrote his own es6-module-filter that uses squares transpiler for broccoli to handle this naming issue: https://github.com/mmun/broccoli-es6-module-transpiler |
\o/ On Tue, Jun 10, 2014 at 4:04 PM, Stefan Penner notifications@github.com
|
this seems no longer relevant, closing due to age |
https://github.com/rpflorence/ember-qunit/blob/master/dist/named-amd/main.js#L22-L23
./isolated-container
is not a sibling of ember-qunit but rather a descendent of it.The text was updated successfully, but these errors were encountered: