Export skip Qunit with wrapper.
#219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| import { skip as qunitSkip } from 'qunit'; | ||
|
|
||
| export default function skip(/* testName, expected, callback, async */) { | ||
| for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; ++_key) { |
There was a problem hiding this comment.
maybe use rest args?
export default function skip(...args) {
}There was a problem hiding this comment.
Happy to make that change; I wrote it this way to keep it in line with e.g. only.
I'd be happy to update only and test as well, if you'd like.
There was a problem hiding this comment.
I'd be happy to update only and test as well, if you'd like.
👍
There was a problem hiding this comment.
This is done locally; I’ll push it up in a little bit.
|
@stefanpenner, I updated with the suggested tweak. Pending the build, should be good to go. |
|
@chriskrycho this looks great, thank you very much :) |
|
My pleasure!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not incidentally, resolves #164 by exporting a wrapping version.