Upgrade QUnit to 2.0 #234
Upgrade QUnit to 2.0 #234
Conversation
trentmwillis
changed the title
|
Tested this with the changes made to
|
|
@trentmwillis this needs a rebase |
|
Rebased. |
| return module.setup().then(function() { | ||
| beforeEach() { | ||
| return module.setup(...arguments).then(() => { | ||
| Object.keys(module.context).forEach((key) => { |
There was a problem hiding this comment.
Lets extract this into https://github.com/rwjblue/ember-qunit/pull/237 for now. I'd prefer to just use QUnit's test context directly as mentioned in a comment over there. I definitely do not see this as a blocker either way though.
|
LGTM with the few tweaks/changes mentioned above. I think we want to land https://github.com/rwjblue/ember-qunit/pull/237 first though. |
|
Will work on this tonight and try to bring in the necessary test adapter changes. |
| if (afterEach) { | ||
| afterEach.call(module.context, assert); | ||
| afterEach.apply(this, arguments); |
There was a problem hiding this comment.
I just noticed that a promise returned from the user's specified afterEach isn't handled properly (meaning we don't block on it before calling module.teardown() just below). We don't need to block this on fixing that, but it would be nice to get it fixed in a future refactor.
There was a problem hiding this comment.
Good catch. I'll do a separate PR for that.
|
@rwjblue I think this should be good to go now. I added in the adapter from the other PR. |
|
Just landed #239 (to allow us to have a final good QUnit 1.x version first), so this will need a rebase. |
|
@rwjblue rebased |
Need to verify what else needs to happen in
ember-cli-qunitbefore proceeding with merging this. Also want to double check behavior of Acceptance tests, since I know of at least this issue: emberjs/ember.js#13696 which we plan to try and fix in this addon instead of in Core.In this PR you'll notice that aside from upgrading QUnit, I also made JSHint stricter and removed the old test wrapper functions, which were primarily there to support promise-returning tests which are now supported in QUnit proper.