New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert.expect to Ember.onerror validation test #315

Merged

rwjblue merged 1 commit into emberjs:master from nlfurniss:master

Feb 16, 2018

Contributor

nlfurniss commented Feb 16, 2018 •

edited

Loading

For projects that enforce QUnit.config.requireExpects, the Ember.onerror validation test causes tests to fail.

This PR:

Adds an assert.expects(1) statement.
Passes all existing tests.


          Add assert.expect to Ember.onerror validation test

e1ddfa3

rwjblue merged commit 6384b76 into emberjs:master

Member

rwjblue commented Feb 16, 2018

Thank you!

rwjblue added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug