Bump minimum required @ember/test-helpers to 0.7.25 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading a few apps to ember and cli 3.2 we noticed test failures attributed to not having the latest test-helpers. This bumps the minimum required version so that apps with older locked dependancies can continue to work.
john-griffin
force-pushed
the
bump-test-helpers
branch
from
6b38477
to
43be85d
Compare
|
Thank you! |
rwjblue
added
enhancement
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading a few apps to ember and cli 3.2 we noticed test failures
attributed to not having the latest test-helpers. This bumps the minimum
required version so that with older projects with locked dependancies can continue to
work.
Will also need to bump min version of ember-qunit used in ember-cli-qunit after the next release, and then the min version of ember-cli-qunit included with cli.