Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin qunit dependency to v2.6.x for Node 4 compatibility #353

Merged
merged 1 commit into from
Oct 13, 2018

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 12, 2018

related to qunitjs/qunit#1321

We can unpin it later, but should officially drop Node 4 support before that and bump major versions here.

/cc @stefanpenner @rwjblue

@rwjblue rwjblue merged commit abcf266 into emberjs:master Oct 13, 2018
@rwjblue
Copy link
Member

rwjblue commented Oct 13, 2018

😭

@Turbo87 Turbo87 deleted the revert-qunit-bump branch October 13, 2018 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants